Page MenuHomePhabricator

Native selection broken after branch node conversion
Closed, ResolvedPublic8 Estimated Story Points

Description

  • Open h1 demo
  • Convert the heading to a paragraph
  • Press undo

Observe the native selection is now above the heading, but the model selection is supposed to be inside the heading. Typing will cause corruption.

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor.
Esanders added subscribers: Esanders, dchan.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 303335 had a related patch set uploaded (by Divec):
Always call back if SurfaceObserver sees a branch node change

https://gerrit.wikimedia.org/r/303335

Change 311371 had a related patch set uploaded (by Divec):
On CBN detach, mark contentBranchNodeChanged in the CE Surface

https://gerrit.wikimedia.org/r/311371

Change 303335 abandoned by Divec:
Always call back if SurfaceObserver sees a branch node change

Reason:
T122291 is better fixed by I0930ac .

https://gerrit.wikimedia.org/r/303335

Change 311371 merged by jenkins-bot:
On CBN detach, mark contentBranchNodeChanged in the CE Surface

https://gerrit.wikimedia.org/r/311371