Page MenuHomePhabricator

Resizing a graph in VisualEditing mode will transform the JSON from block to inline
Closed, ResolvedPublic1 Story Points

Description

I have inserted a graph in VisualEditing mode. Saved the page. Reopened the page in VisualEditing. Resized the graph using the arrows in the lowerright corner. Saved the paged. Checked the source and found the JSON specification has been collapsed from block to inline formatting.

Event Timeline

AdHuikeshoven raised the priority of this task from to Needs Triage.
AdHuikeshoven updated the task description. (Show Details)
AdHuikeshoven added a project: VisualEditor.
Jdforrester-WMF triaged this task as Low priority.Jan 19 2016, 8:06 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Isn't this intended? The JSON shouldn't be stored inline, I thought?

This is due to the graph extension stylesheet not being loaded the first time a graph is created on a page, resulting in VE wrongly displaying them as blocks. According to the stylesheet graphs should always be displayed as an inline-block.

Change 312794 had a related patch set uploaded (by Ferdbold):
Display graphs as inline-blocks at first creation Fix popup widget displaying as anchored after resizing a graph

https://gerrit.wikimedia.org/r/312794

Change 312794 merged by jenkins-bot:
Display graphs as inline-blocks at first creation Fix popup widget displaying as anchored after resizing a graph

https://gerrit.wikimedia.org/r/312794

Jdforrester-WMF moved this task from Freezer to Blocked on the VisualEditor board.Oct 3 2016, 8:03 PM
Jdforrester-WMF moved this task from Blocked to External and Administrivia on the VisualEditor board.
Jdforrester-WMF closed this task as Resolved.Oct 3 2016, 8:09 PM