Page MenuHomePhabricator
Create Task
Maniphest T122362

Use static arrays for Interwiki cache in Wikimedia production (instead of cdb files)
Closed, ResolvedPublic
Actions

Description

@ori wrote at https://gerrit.wikimedia.org/r/250301

For the same reasons wikiversions.cdb was converted to a PHP file -- viz., that
static arrays in PHP files get cached in HHVM's bytecode cache and are
therefore faster to use with HHVM than CDB files.

See also: T99740: Use static php array files for l10n cache at WMF (instead of CDB)

Details

SubjectRepoBranchLines +/-
dumpInterwiki: make stdout output valid PHP codemediawiki/extensions/WikimediaMaintenancewmf/1.27.0-wmf.13+14 -2
dumpInterwiki: make stdout output valid PHP codemediawiki/extensions/WikimediaMaintenancemaster+14 -2
interwiki: Fix-up for I5a979f047031emediawiki/corewmf/1.27.0-wmf.13+6 -8
interwiki: Fix-up for I5a979f047031emediawiki/coremaster+6 -8
Add interwiki.php; use it on mw1017 & on labsoperations/mediawiki-configmaster+12 K -1
Remove interwiki.cdboperations/mediawiki-configmaster+0 -0
Use interwiki.php on all wikis; delete unused interwiki.jsonoperations/mediawiki-configmaster+1 -7
Allow $wgInterwikiCache to be an associative arraymediawiki/coremaster+30 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Dec 23 2015, 10:23 PM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: MediaWiki-Interwiki, HHVM, Performance-Team.
Krinkle added subscribers: Krinkle, ori.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 23 2015, 10:23 PM
gerritbot subscribed.Dec 23 2015, 10:23 PM

Change 250301 had a related patch set uploaded (by Krinkle):
Allow $wgInterwikiCache to be an associative array

https://gerrit.wikimedia.org/r/250301

gerritbot added a project: Patch-For-Review.Dec 23 2015, 10:23 PM
gerritbot added a comment.Dec 23 2015, 10:40 PM

Change 250301 merged by jenkins-bot:
Allow $wgInterwikiCache to be an associative array

https://gerrit.wikimedia.org/r/250301

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes.Dec 23 2015, 11:00 PM
Krinkle removed projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review.Dec 24 2015, 4:25 AM
Krinkle set Security to None.
Krinkle updated the task description. (Show Details)Jan 4 2016, 10:44 PM
Nemo_bis added a subtask: T99740: Use static php array files for l10n cache at WMF (instead of CDB).Jan 5 2016, 11:54 AM
Nemo_bis edited projects, added Wikimedia-Interwiki-links; removed MediaWiki-Interwiki.
Krinkle triaged this task as Medium priority.Jan 6 2016, 7:55 PM
Krinkle removed a subtask: T99740: Use static php array files for l10n cache at WMF (instead of CDB).

Removing T99740 as blocker. This can be a regular php file references in wmf-config. It's not nearly as large and frequently changing as i18n to warrant a block on Repo-Auth mode. It'll be like any other file in wmf-config that can change with deployments.

gerritbot added a comment.Feb 8 2016, 8:23 PM

Change 269201 had a related patch set uploaded (by Ori.livneh):
Add interwiki.php; use it on mw1017 & on labs

https://gerrit.wikimedia.org/r/269201

gerritbot added a project: Patch-For-Review.Feb 8 2016, 8:23 PM
gerritbot added a comment.Feb 8 2016, 8:57 PM

Change 269217 had a related patch set uploaded (by Ori.livneh):
dumpInterwiki: make stdout output valid PHP code

https://gerrit.wikimedia.org/r/269217

gerritbot added a comment.Feb 8 2016, 9:17 PM

Change 269201 merged by Ori.livneh:
Add interwiki.php; use it on mw1017 & on labs

https://gerrit.wikimedia.org/r/269201

gerritbot added a comment.Feb 8 2016, 9:45 PM

Change 269297 had a related patch set uploaded (by Ori.livneh):
Use interwiki.php on all wikis; delete unused interwiki.json

https://gerrit.wikimedia.org/r/269297

gerritbot added a comment.Feb 8 2016, 9:47 PM

Change 269297 merged by jenkins-bot:
Use interwiki.php on all wikis; delete unused interwiki.json

https://gerrit.wikimedia.org/r/269297

gerritbot added a comment.Feb 8 2016, 10:40 PM

Change 269318 had a related patch set uploaded (by Ori.livneh):
Remove interwiki.cdb

https://gerrit.wikimedia.org/r/269318

ori closed this task as Resolved.Feb 8 2016, 10:42 PM
ori claimed this task.
gerritbot added a comment.Feb 8 2016, 11:24 PM

Change 269329 had a related patch set uploaded (by Ori.livneh):
Fix-up for I5a979f047031e

https://gerrit.wikimedia.org/r/269329

gerritbot added a comment.Feb 8 2016, 11:32 PM

Change 269318 merged by Ori.livneh:
Remove interwiki.cdb

https://gerrit.wikimedia.org/r/269318

gerritbot added a comment.Feb 9 2016, 8:31 PM

Change 269329 merged by jenkins-bot:
interwiki: Fix-up for I5a979f047031e

https://gerrit.wikimedia.org/r/269329

gerritbot added a comment.Feb 10 2016, 8:16 PM

Change 269814 had a related patch set uploaded (by Chad):
interwiki: Fix-up for I5a979f047031e

https://gerrit.wikimedia.org/r/269814

gerritbot added a comment.Feb 10 2016, 8:17 PM

Change 269814 merged by Chad:
interwiki: Fix-up for I5a979f047031e

https://gerrit.wikimedia.org/r/269814

gerritbot added a comment.Feb 12 2016, 5:50 PM

Change 270328 had a related patch set uploaded (by Alex Monk):
dumpInterwiki: make stdout output valid PHP code

https://gerrit.wikimedia.org/r/270328

gerritbot added a comment.Feb 12 2016, 6:00 PM

Change 269217 merged by jenkins-bot:
dumpInterwiki: make stdout output valid PHP code

https://gerrit.wikimedia.org/r/269217

gerritbot added a comment.Feb 12 2016, 6:00 PM

Change 270328 merged by jenkins-bot:
dumpInterwiki: make stdout output valid PHP code

https://gerrit.wikimedia.org/r/270328

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-02-16_(1.27.0-wmf.14)), MW-1.27-release-notes.Feb 12 2016, 11:02 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)).Feb 16 2016, 4:02 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 16 2016, 7:02 PM
Krinkle mentioned this in T127780: Convert Wikihiero to use static array files instead of ".ser" files (serialised php text).Feb 23 2016, 1:07 AM
Krinkle mentioned this in T156924: Allow integration of data from etcd into the MediaWiki configuration.Mar 4 2017, 2:55 AM
Krinkle mentioned this in T16164: Interwiki cache should be shared when Interwiki table is shared.May 24 2017, 12:25 PM
Krinkle added a parent task: T212460: Adopt static array files for local disk storage of values (epic).Dec 20 2018, 9:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL