Page MenuHomePhabricator

Fatal error: SemanticForms accessing Cargo private property
Closed, ResolvedPublic

Description

Semantic Form accessing Cargo private property yields fatal error when editing form

class CargoFieldDescription {
    ...
    public $mDelimiter;

was recently changed to

class CargoFieldDescription {
    ...
    private $mDelimiter;

which causes the following error "Fatal error: Cannot access private property CargoFieldDescription::$mDelimiter in /www-wiki/core/extensions/SemanticForms/includes/SF_TemplateField.php on line 160"

Fix would consist in scanning for accesses to mDelimiter and replacing it with getDelimiter() which was also recently introduced as

function getDelimiter() {
        // Make "\n" represent a newline.
        return str_replace( '\n', "\n", $this->mDelimiter );
}

Event Timeline

EdHoo created this task.Dec 28 2015, 5:40 PM
EdHoo raised the priority of this task from to High.
EdHoo updated the task description. (Show Details)
EdHoo added subscribers: EdHoo, Yaron_Koren.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 28 2015, 5:40 PM
EdHoo renamed this task from Fatal error: Semantic Form accessing Cargo private property to Fatal error: SemanticForms accessing Cargo private property.Dec 28 2015, 5:40 PM
EdHoo set Security to None.
EdHoo claimed this task.Dec 28 2015, 6:01 PM

Change 261211 had a related patch set uploaded (by Ed Hoo):
Fix fatal error where SemanticForms accesses Cargo private property

https://gerrit.wikimedia.org/r/261211

EdHoo closed this task as Resolved.Dec 28 2015, 6:30 PM

Change 261211 abandoned by Ed Hoo:
Fix fatal error where SemanticForms accesses Cargo private property

Reason:
Fix already in place by a different patch

https://gerrit.wikimedia.org/r/261211