Page MenuHomePhabricator

Cache rollback edit counts shown on recent changes
Open, MediumPublic

Description

To cut down on recent changes queries (as it used to be good in this regard), it would be nice to use memcached for the rollback edit count code added in https://gerrit.wikimedia.org/r/#/c/16932/ .

Could use page_latest in the key (since the links are only for "top" edits and this would handle invalidation).

Event Timeline

aaron raised the priority of this task from to Needs Triage.
aaron updated the task description. (Show Details)
aaron added a project: Performance Issue.
aaron added subscribers: aaron, Parent5446.
kostajh added subscribers: Krinkle, kostajh.

@aaron @Krinkle is this something Performance-Team plans to work on? Seems like a good idea, but Growth-Team doesn't have bandwidth to do it in the short-to-medium term.

I guess it can go on our backlog.

OK, thanks for letting us know.

Krinkle triaged this task as Medium priority.Jul 24 2019, 4:13 PM
This comment was removed by Krinkle.

In miser mode, recent changes and watchlist do not display the edit count (Linker::buildRollbackLink). But the views call Linker::generateRollback, which calls Linker::getRollbackEditCount regardless. So the edit count is always computed, it isn't just displayed. This is probably a bug.

In miser mode, recent changes and watchlist do not display the edit count (Linker::buildRollbackLink). But the views call Linker::generateRollback, which calls Linker::getRollbackEditCount regardless. So the edit count is always computed, it isn't just displayed. This is probably a bug.

That was changed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/867732, after on ChangesList (that is for watchlist/rc) and ContribsPager there was no verifiy parameter to Linker::generateRollback and that results in always getting the count. (with mitigation for performance in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/870738, the verify was removed later in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/871018). So this has a visible impact on wiki for rollback users, as there are no more useless rollback links on Special:Watchlist/RecentChanges or Special:Contributions.