Page MenuHomePhabricator

Cargo passing parameters to CargoStore not thread safe
Open, MediumPublic

Description

CargoStore::$settings is used to pass parameters to CargoStore. When we have multiple pages and/or templates being saved within a short period of time the values in CargoStore::$settings keep getting overwritten over and over so that by the time page 'N' is being stored the parameters passed in $settings relate to page 'N+1' or 'N+2', etc.

Details

Related Gerrit Patches:

Event Timeline

EdHoo created this task.Dec 29 2015, 3:49 AM
EdHoo claimed this task.
EdHoo raised the priority of this task from to Medium.
EdHoo updated the task description. (Show Details)
EdHoo added subscribers: EdHoo, Yaron_Koren.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2015, 3:49 AM

Change 261317 had a related patch set uploaded (by Ed Hoo):
Use parser options to provide context to CargoStore persistence

https://gerrit.wikimedia.org/r/261317

Aklapper moved this task from Doing to Backlog on the MediaWiki-extensions-Cargo board.

@EdHoo: Sorry that this never received a review. The task in Gerrit needs rebasing. Are you still interested in working on this? Asking as you are task assignee.

Apologies, I'm no longer involved in development work.

Aklapper removed EdHoo as the assignee of this task.Wed, Mar 25, 10:46 PM

No problem. :) Thanks for the quick answer!