Page MenuHomePhabricator

setMwGlobals doesn't seem to always work in unit tests on arrays
Closed, InvalidPublic

Description

Run

php phpunit.php includes/GlobalFunctions/

In LocalSettings.php add

$wgUrlProtocols = array();

php phpunit.php includes/GlobalFunctions/ fails

Also altering $wgResourceLoaderLESSVars in DefaultSettings.php seems to impact resourceloader/ResourceLoaderTest.php (see https://gerrit.wikimedia.org/r/261457) the values defined via setMwGlobals no longer seem to be correct.

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 29 2015, 7:31 PM
Jdlrobson updated the task description. (Show Details)Dec 29 2015, 7:52 PM
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

Change 261570 had a related patch set uploaded (by Addshore):
Add more cases to MediaWikiTestCaseTest

https://gerrit.wikimedia.org/r/261570

Change 261570 merged by jenkins-bot:
Add more cases to MediaWikiTestCaseTest

https://gerrit.wikimedia.org/r/261570

Well, per the test added the base class seems to be doing what it should :/
This may need more investigation?

Krinkle closed this task as Invalid.Jan 12 2017, 8:15 PM
Krinkle triaged this task as Normal priority.