The cancel event handler closes the ULS even if a descendant of the trigger is clicked
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Victorbarbu
	Jan 1 2016, 2:56 PM

Description

In the cancel event handler, the ULS window will be closed if any element other than the ULS trigger is clicked, even if that element is a descendant of the ULS trigger. This is a problem when the ULS trigger is an OOjs UI button.

Details

	Subject	Repo	Branch	Lines +/-
	Fix the cancel event function to prevent erroneous close	mediawiki/extensions/UniversalLanguageSelector	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Victorbarbu	T87244 Use ULS for language selection
		Resolved		Victorbarbu	T122722 The cancel event handler closes the ULS even if a descendant of the trigger is clicked

Event Timeline

Victorbarbu created this task.Jan 1 2016, 2:56 PM

Victorbarbu claimed this task.

Victorbarbu raised the priority of this task from to Medium.

Victorbarbu updated the task description. (Show Details)

Victorbarbu added a project: UniversalLanguageSelector.

Victorbarbu added subscribers: Victorbarbu, TTO.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 1 2016, 2:56 PM

Change 261810 had a related patch set uploaded (by Victorbarbu):
Fix the cancel event function to prevent erroneous close

https://gerrit.wikimedia.org/r/261810

gerritbot added a project: Patch-For-Review.Jan 1 2016, 3:02 PM

Change 261810 merged by jenkins-bot:
Fix the cancel event function to prevent erroneous close

https://gerrit.wikimedia.org/r/261810

Ahem @TTO, thanks for looking into this but this should not have been merged in gerrit first. This is an upstream library, the patch needs to be in https://github.com/wikimedia/jquery.uls too.