Page MenuHomePhabricator

The cancel event handler closes the ULS even if a descendant of the trigger is clicked
Closed, ResolvedPublic

Description

In the cancel event handler, the ULS window will be closed if any element other than the ULS trigger is clicked, even if that element is a descendant of the ULS trigger. This is a problem when the ULS trigger is an OOjs UI button.

Event Timeline

Victorbarbu updated the task description. (Show Details)
Victorbarbu raised the priority of this task from to Normal.
Victorbarbu claimed this task.
Victorbarbu added subscribers: Victorbarbu, TTO.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 1 2016, 2:56 PM

Change 261810 had a related patch set uploaded (by Victorbarbu):
Fix the cancel event function to prevent erroneous close

https://gerrit.wikimedia.org/r/261810

Change 261810 merged by jenkins-bot:
Fix the cancel event function to prevent erroneous close

https://gerrit.wikimedia.org/r/261810

Nemo_bis added a subscriber: Nemo_bis.

Ahem @TTO, thanks for looking into this but this should not have been merged in gerrit first. This is an upstream library, the patch needs to be in https://github.com/wikimedia/jquery.uls too.

TTO added a comment.Jan 1 2016, 3:16 PM

Whoops, didn't even think to check that :(

Nemo_bis closed this task as Resolved.Jan 3 2016, 8:26 PM

Thanks Santhosh for the merge, I assume this is fixed.