Page MenuHomePhabricator
Create Task
Maniphest T122738

MediaWiki-Codesniffer sniffs the .git folder
Closed, ResolvedPublic
Actions

Description

Since mw codesniffer 0.5.1 has been released it has been sniffing the .git folder as it did at https://gerrit.wikimedia.org/r/#/c/248379/

It should not be doing that since the .git folder only has information for the git programme.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Exclude common foldersmediawiki/tools/codesniffermaster+5 -0
Customize query in gerrit

Event Timeline

Paladox created this task.Jan 2 2016, 12:02 PM
Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a project: MediaWiki-Codesniffer.
Paladox subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 2 2016, 12:02 PM
Paladox set Security to None.Jan 2 2016, 12:02 PM
Paladox added a subscriber: Legoktm.
Aklapper renamed this task from Bug in MW codesniffer 0.5.1 now sniffs the .git folder to Codesniffer 0.5.1 now sniffs the .git folder.Jan 4 2016, 3:57 AM
Legoktm added a comment.Jan 4 2016, 5:34 AM

Is this an upstream change...? We didn't change anything in mw-cs I think...

Legoktm added a comment.Jan 19 2016, 7:27 AM

Hmm, I can't reproduce:

km@km-tp ~/p/v/m/e/AbsenteeLandlord> ./vendor/bin/phpcs -v 
Registering sniffs in the  standard... DONE (54 sniffs registered)
Creating file list... DONE (1 files in queue)
Changing into directory /home/km/projects/vagrant/mediawiki/extensions/AbsenteeLandlord
Processing AbsenteeLandlord.php [PHP => 410 tokens in 58 lines]... DONE in 14ms (0 errors, 0 warnings)
Legoktm added a comment.Jan 19 2016, 7:30 AM

Oh, no. I just had to create a .php file inside .git:

km@km-tp ~/p/s/AbsenteeLandlord> ./vendor/bin/phpcs -v
Registering sniffs in the  standard... DONE (54 sniffs registered)
Creating file list... DONE (2 files in queue)
Changing into directory /home/km/projects/sandbox/AbsenteeLandlord
Processing AbsenteeLandlord.php [PHP => 410 tokens in 58 lines]... DONE in 13ms (0 errors, 0 warnings)
Changing into directory /home/km/projects/sandbox/AbsenteeLandlord/.git
Processing test.php [PHP => 0 tokens in 0 lines]... DONE in 0ms (0 errors, 1 warnings)
Legoktm added a comment.Jan 19 2016, 7:38 AM

After further testing, it appears this isn't a new problem to 0.5.1. I can reproduce this issue going all the way back to 0.1.0.

Legoktm renamed this task from Codesniffer 0.5.1 now sniffs the .git folder to MediaWiki-Codesniffer sniffs the .git folder.Jan 19 2016, 7:39 AM
polybuildr subscribed.Jan 19 2016, 7:46 AM

I'm guessing we just need to add it to the ignored patterns in phpcs.xml?

polybuildr added a comment.Jan 19 2016, 7:51 AM

Sorry, while phpcs.xml works for individual repositories, we should probably be changing this in ruleset.xml using <exclude-pattern> I think.

gerritbot subscribed.Jun 29 2017, 6:54 PM

Change 362266 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/codesniffer@master] Exclude common folder

https://gerrit.wikimedia.org/r/362266

gerritbot added a project: Patch-For-Review.Jun 29 2017, 6:54 PM
gerritbot added a comment.Jun 30 2017, 12:11 AM

Change 362266 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Exclude common folders

https://gerrit.wikimedia.org/r/362266

Umherirrender closed this task as Resolved.Jun 30 2017, 4:40 AM
Umherirrender claimed this task.
Umherirrender triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits