Page MenuHomePhabricator

Incorrect end tags for <source> and <track>
Closed, ResolvedPublic

Description

The <source> and <track> elements in videos are incorrectly written as <source></source> instead of <source />, see e.g. https://html5.validator.nu/?doc=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FWikipedia%3AVideos&submit=Check.

As the code actually looks good, and it only happens on user generated pages, not on file description pages, I guess that HTML tidy is the culprit.

Event Timeline

Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark added a project: TimedMediaHandler.
Schnark added a subscriber: Schnark.

Change 262347 had a related patch set uploaded (by TheDJ):
Tidy: <source> and <track> are empty elements

https://gerrit.wikimedia.org/r/262347

Change 272329 had a related patch set uploaded (by TheDJ):
Correct parser test with tidy config

https://gerrit.wikimedia.org/r/272329

Change 262347 merged by Brion VIBBER:
Tidy: <source> and <track> are empty elements

https://gerrit.wikimedia.org/r/262347

Change 272329 merged by jenkins-bot:
Correct parser test with tidy config

https://gerrit.wikimedia.org/r/272329