Maniphest T122787

Incorrect end tags for <source> and <track>
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Jan 4 2016, 9:36 AM

Tags

Referenced Files

None

Subscribers

Description

The <source> and <track> elements in videos are incorrectly written as <source></source> instead of <source />, see e.g. https://html5.validator.nu/?doc=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FWikipedia%3AVideos&submit=Check.

As the code actually looks good, and it only happens on user generated pages, not on file description pages, I guess that HTML tidy is the culprit.

Details

	Subject	Repo	Branch	Lines +/-
	Correct parser test with tidy config	mediawiki/extensions/TimedMediaHandler	master	+2 -1
	Tidy: <source> and <track> are empty elements	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		TheDJ	T122787 Incorrect end tags for <source> and <track>
		Resolved		TheDJ	T126723 Create parser tests for audio/video elements generated by TimedMediaHandler

Event Timeline

Schnark created this task.Jan 4 2016, 9:36 AM

Schnark raised the priority of this task from to Needs Triage.

Schnark updated the task description. (Show Details)

Schnark added a project: TimedMediaHandler.

Schnark subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 4 2016, 9:36 AM

Schnark added a parent task: T4542: [DO NOT USE] HTML Tidy issues (tracking) [superseded by the #Tidy tag].Jan 4 2016, 9:36 AM

TheDJ subscribed.Jan 4 2016, 2:08 PM

Change 262347 had a related patch set uploaded (by TheDJ):
Tidy: <source> and <track> are empty elements

https://gerrit.wikimedia.org/r/262347

gerritbot added a project: Patch-For-Review.Jan 4 2016, 2:12 PM

TheDJ added a subtask: T126723: Create parser tests for audio/video elements generated by TimedMediaHandler.Feb 12 2016, 10:04 AM

TheDJ moved this task from To sort to Doing on the TimedMediaHandler board.Feb 18 2016, 3:35 PM

Change 272329 had a related patch set uploaded (by TheDJ):
Correct parser test with tidy config

https://gerrit.wikimedia.org/r/272329

Change 262347 merged by Brion VIBBER:
Tidy: <source> and <track> are empty elements

https://gerrit.wikimedia.org/r/262347

Change 272329 merged by jenkins-bot:
Correct parser test with tidy config

https://gerrit.wikimedia.org/r/272329

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 22 2016, 4:00 PM

TheDJ closed this task as Resolved.Feb 22 2016, 4:02 PM

TheDJ claimed this task.

TheDJ closed subtask T126723: Create parser tests for audio/video elements generated by TimedMediaHandler as Resolved.

TheDJ moved this task from Doing to Done on the TimedMediaHandler board.Feb 22 2016, 4:18 PM

Danny_B added a project: Tidy.May 28 2016, 10:31 AM

Danny_B removed a parent task: T4542: [DO NOT USE] HTML Tidy issues (tracking) [superseded by the #Tidy tag].May 28 2016, 10:50 AM