Page MenuHomePhabricator

Missing items in package __all__
Closed, ResolvedPublic

Description

The following classes and functions in pywikibot/__init__.py are missing from the __all__ variable in the pywikibot package.

Functions:

  • Site (T122563)
  • setAction
  • showDiff
  • stopme
  • async_manager
  • async_request

Classes:

  • Timestamp
  • Coordinate
  • WbTime
  • WbQuantity

Most of these are not exposed as package level items in compat, so they do not need to be exposed as package level items in core, but they do need to be exposed in a module (i.e. they could be moved out of __init__ to become exposed.
And some may be intentionally hidden members; e.g. async_manager and stopme do not need to be exposed at all.

Event Timeline

jayvdb raised the priority of this task from to High.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot.
jayvdb subscribed.
jayvdb set Security to None.

Change 629062 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] Add some classes and functions to all variable in pywikibot

https://gerrit.wikimedia.org/r/629062

Change 629062 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Add some classes and functions to all variable in pywikibot

https://gerrit.wikimedia.org/r/629062