Page MenuHomePhabricator
Create Task
Maniphest T122952

convertExtensionToRegistration.php script should die on global functions (like it does for closures)
Closed, ResolvedPublic
Actions

Description

The convertExtensionToRegistration.php script should die, if global functions are used for wgExtensionFunctions and Hooks (like it does for closures).

Details

SubjectRepoBranchLines +/-
convertExtensionToRegistration.php: die on global functionsmediawiki/coremaster+12 -0
Customize query in gerrit

Event Timeline

Legoktm created this task.Jan 6 2016, 5:44 AM
Legoktm raised the priority of this task from to Medium.
Legoktm updated the task description. (Show Details)
Legoktm added projects: MediaWiki-Configuration, good first task.
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2016, 5:44 AM
xSavitar subscribed.Jan 7 2016, 12:33 AM
Nemo_bis added a project: Google-Code-In-2015.Jan 7 2016, 9:01 PM
Nemo_bis set Security to None.
Legoktm added a comment.Jan 8 2016, 6:19 PM

https://codein.withgoogle.com/dashboard/tasks/5711651110125568/

Nemo_bis moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Jan 8 2016, 6:34 PM
Victorbarbu claimed this task.Jan 9 2016, 7:19 PM
Victorbarbu subscribed.

I am working on it!

Florian updated the task description. (Show Details)Jan 9 2016, 7:23 PM
gerritbot subscribed.Jan 9 2016, 7:30 PM

Change 263182 had a related patch set uploaded (by Victorbarbu):
Make convertExtensionToRegistration.php die on global functions

https://gerrit.wikimedia.org/r/263182

gerritbot added a project: Patch-For-Review.Jan 9 2016, 7:30 PM
gerritbot added a comment.Jan 9 2016, 9:56 PM

Change 263182 merged by jenkins-bot:
convertExtensionToRegistration.php: die on global functions

https://gerrit.wikimedia.org/r/263182

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 9 2016, 10:00 PM
Victorbarbu closed this task as Resolved.Jan 9 2016, 10:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL