Page MenuHomePhabricator
Create Task
Maniphest T122956

Wikipedia doc_subpages not set
Closed, ResolvedPublic
Actions

Description

0f18c5163 introduced Family.doc_subpage, with values for Wikipedia and Wikisource. The Wikipedia value was added in a way that the value is never actually set, as it is in unexecuted code after a return.

Details

SubjectRepoBranchLines +/-
[Fix]: Set properly Wikipedia doc_subpages in Family()pywikibot/coremaster+23 -23
Customize query in gerrit

Related Objects

Event Timeline

jayvdb created this task.Jan 6 2016, 12:48 PM
jayvdb assigned this task to Mpaa.
jayvdb raised the priority of this task from to High.
jayvdb updated the task description. (Show Details)
jayvdb added projects: Pywikibot, good first task.
jayvdb subscribed.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 6 2016, 12:48 PM
jayvdb mentioned this in T122958: Analyse and fix issues highlighted by QuantifiedCode.Jan 6 2016, 1:33 PM
gerritbot subscribed.Jan 6 2016, 6:37 PM

Change 262724 had a related patch set uploaded (by Mpaa):
[Fix]: Set prperly Wikipedia doc_subpages in Famly().

https://gerrit.wikimedia.org/r/262724

gerritbot added a project: Patch-For-Review.Jan 6 2016, 6:37 PM
gerritbot added a comment.Jan 6 2016, 9:02 PM

Change 262724 merged by jenkins-bot:
[Fix]: Set properly Wikipedia doc_subpages in Family()

https://gerrit.wikimedia.org/r/262724

Mpaa closed this task as Resolved.Jan 6 2016, 9:49 PM
Mpaa set Security to None.
Ricordisamoa removed a project: Patch-For-Review.Jan 7 2016, 11:43 AM
Ricordisamoa removed a subscriber: gerritbot.
jayvdb mentioned this in T121948: Pywikibot 2.0rc5.Jan 7 2016, 12:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL