Page MenuHomePhabricator

Analyse and fix issues highlighted by QuantifiedCode
Closed, DeclinedPublic

Description

https://www.quantifiedcode.com/app/project/gh:jayvdb:pywikibot-core shows quite a few real problems.
They have useful between commit reports showing changes:
https://www.quantifiedcode.com/app/project/gh:jayvdb:pywikibot-core/diff/805f4cbdd3f6b0b850d98e6d952922bb245fbd24/f96151900aa1c281bebab5136534881a33e39052/issues?issue_type=added

It might be helpful to identify what checker they are using. http://docs.quantifiedcode.com/faq/analysis/linters_which.html says they "pylint, pyflakes, phpmd, jslint" , which seems a little strange as they only support Python.

It looks like many are their own custom Cody rules.

T74697: Add pylint checking would probably catch most of these.

  • Remove unreachable code
  • else clause on a loop without a break statement
    • ignore ; the checker is not smart enough

Event Timeline

jayvdb raised the priority of this task from to High.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot.
jayvdb subscribed.
jayvdb set Security to None.
Xqt subscribed.

No longer reachable