Page MenuHomePhabricator

Live preview does not display map (from Mapframe template) on English wikivoyage
Closed, InvalidPublic

Description

When live preview is used with {{Mapframe}} template on English wikivoyage, there won't be any preview of map like in normal preview. But using normal preview is incredibly slow while adding Mapframe templates to wikivoyage entries.

Please see the gif for reference.

Event Timeline

phabyogi raised the priority of this task from to Low.
phabyogi updated the task description. (Show Details)
phabyogi added a subscriber: phabyogi.

Confirming after enabling "Use live preview" on https://en.wikivoyage.org/wiki/Special:Preferences#mw-prefsection-editing and going to https://en.wikivoyage.org/w/index.php?title=Ahmedabad/South_Zone&action=edit and clicking the "Show Preview" button however I'm not sure how complicated that would be to fix.

Aklapper renamed this task from Live preview doesn't work with Mapframe template on English wikivoyage to Live preview does not display map (from Mapframe template) on English wikivoyage.Jan 7 2016, 4:14 PM
Aklapper lowered the priority of this task from Low to Lowest.
Aklapper set Security to None.

@Aklapper, thank you for correcting the title! But any reason to change the task priority to Lowest from Low? Because of the T41272 blocked task?

Aklapper claimed this task.

Thanks Fomafix!

User scripts, gadgets and templates are local features and managed on wiki. Phabricator/Maniphest is used for MediaWiki, MediaWiki extensions, or server configuration. You could contact the author of the script/gadget. Closing as INVALID here in Phabricator as this is a matter to discuss and fix on the local wiki and unfortunately not handled in Phabricator/Maniphest.

In case anyone on wikivoyage wants to fix the script, you're looking at something like:

function insertIFrame( $content ) {
    $content.find( '#mapwrap' ); <!-- similar changes for all other $jquery lookups -->
}

jQuery(document).ready(insertIFrame); -> mw.hook( 'wikipage.content' ).add( insertIFrame );

Thanks @Aklapper and others here!
Will discuss this on local wiki and request there to fix the same.

I integrated the change applied the coding conventions and fixed a security issue: