Page MenuHomePhabricator
Create Task
Maniphest T123080

Moment.js does not support all Chinese languages that MediaWiki supports
Closed, ResolvedPublic
Actions

Description

For example, in Resources.php, localization for momentjs is defined for zh-CN, zh-TW, but not for zh-Hans, zh-Hant, etc. This will cause modules depending on momentjs to display English fallback if the interface language for the user is zh-Hans, for example.

Details

SubjectRepoBranchLines +/-
Define 'zh-hans' and 'zh-hant' localisations for Moment.jsmediawiki/coremaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Nbdd0121 created this task.Jan 7 2016, 6:20 PM
Nbdd0121 raised the priority of this task from to Needs Triage.
Nbdd0121 updated the task description. (Show Details)
Nbdd0121 subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 7 2016, 6:20 PM
Krenair added a project: MediaWiki-General.Jan 7 2016, 11:57 PM
Krenair subscribed.
Aklapper added a project: I18n.Jan 9 2016, 1:00 AM
Liuxinyu970226 subscribed.Jan 15 2016, 11:33 PM
gerritbot subscribed.Mar 24 2016, 6:47 PM

Change 279416 had a related patch set uploaded (by Nbdd0121):
Fix T123080

https://gerrit.wikimedia.org/r/279416

gerritbot added a project: Patch-For-Review.Mar 24 2016, 6:47 PM
matmarex renamed this task from Libraries used by MediaWiki do not support all languages MediaWiki supported to Moment.js does not support all Chinese languages that MediaWiki supports.Mar 24 2016, 7:49 PM
matmarex set Security to None.
matmarex subscribed.
gerritbot added a comment.Mar 24 2016, 7:55 PM

Change 279416 had a related patch set uploaded (by Bartosz Dziewoński):
Define 'zh-hans' and 'zh-hant' localisations for Moment.js

https://gerrit.wikimedia.org/r/279416

gerritbot added a comment.Mar 24 2016, 8:49 PM

Change 279416 merged by jenkins-bot:
Define 'zh-hans' and 'zh-hant' localisations for Moment.js

https://gerrit.wikimedia.org/r/279416

matmarex closed this task as Resolved.Mar 24 2016, 8:49 PM
matmarex assigned this task to Nbdd0121.

Thanks for the patch! The change has been merged and will be deployed to Wikimedia wikis next week, with MediaWiki version 1.27.0-wmf.19, according to the schedule at https://www.mediawiki.org/wiki/MediaWiki_1.27/Roadmap.

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 24 2016, 9:00 PM
Nbdd0121 merged a task: T122768: momentjs does not support zh zh-hans zh-hant?.Mar 24 2016, 10:20 PM
Nbdd0121 added subscribers: Krinkle, Zoglun.
Liuxinyu970226 unsubscribed.Mar 25 2016, 9:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL