Page MenuHomePhabricator

Update Commit Message Guidelines for Differential
Closed, DeclinedPublic

Description

If a user uploads a patch to phab via arcanist, he have to choose a different commit message as before. Here is an overview about the problem (that I found):

Fields

Summary

  • I think the summary should contain a summary like at gerrit, but instead of "Bug: T2000" at the end of the commit (if you don't read the change-id) the user should write something like "Ref T2000". He can write Bug: T2000 or Task: T2000 too, but he havt to do this at the summary.

Testplan

  • Do we want to use the testplan?
    • Which information should this field include? Does the user have to fill it?

Revertplan

  • Do we want to enable the optional field "RevertPlan" for difficult changes or something like that? Currently it is disabled....

Projects

I think it is very useful, if the user should add projects. It is easy via Arcanist, but we have to write it into the guidelines

Reviewers

Should the user add reviewers?

Autoclose?

Do we want to have autoclose at the message? This requires an additional "Fixes T2000" at the message. Maybe instead of Ref T2000 etc?

To be continued...

Event Timeline

Luke081515 updated the task description. (Show Details)
Luke081515 raised the priority of this task from to Needs Triage.
Luke081515 added a project: Gerrit-Migration.
Luke081515 added a subscriber: Luke081515.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 7 2016, 6:22 PM
Luke081515 renamed this task from Update Commit Message Guidlines for phab to Update Commit Message Guidelines for phab.Jan 7 2016, 6:36 PM
Luke081515 updated the task description. (Show Details)
Luke081515 set Security to None.

Yeah, we need to change the arcanist specific stuff.

greg moved this task from To Triage to Tooling on the Gerrit-Migration board.Jan 20 2016, 12:48 AM
mmodell added a subscriber: mmodell.Mar 7 2016, 8:41 PM

I like the Test Plan field. I'm not so sure if it should be required though. Generally for code that is getting deployed to production, I think even having a revert plan makes sense. Sometime in the future, Release-Engineering-Team might like to require the test plan and/or revert plan.

greg triaged this task as Normal priority.Mar 15 2016, 10:04 PM
greg removed a subscriber: StudiesWorld.
greg moved this task from Tooling to Documentation on the Gerrit-Migration board.Mar 15 2016, 10:59 PM
greg renamed this task from Update Commit Message Guidelines for phab to Update Commit Message Guidelines for Differential.Mar 23 2016, 10:54 PM
greg added a project: Differential.
greg moved this task from To Triage to Backlog on the Differential board.May 12 2016, 10:37 PM
demon closed this task as Declined.Mar 7 2018, 10:10 PM
demon added a subscriber: demon.