Page MenuHomePhabricator

VisualEditor doesn't handle login timeouts well in MW 1.26
Closed, DeclinedPublic1 Estimated Story Points

Description

Using MW 1.26 I have two issues:

  • When I have previously been logged in but my login has timed out and I click 'Edit' on a page open in my browser I receive an "readapidenied" error. I should be redirected to a login page.
  • When I have previously been editing and I click save in Visual Editor if my login has timed out, it will allow me to go through as if I was saving but it never completes (hangs indefinitely). Either (a) VisualEditor should cache and refresh login credentials or (b) VisualEditor should "auto-save" or "stash" edits or (c) VisualEditor should redirect me to a login page.

It's possible my configuration is imperfect but my Google-fu has not revealed discussion of this issue.

Event Timeline

Dan.mulholland raised the priority of this task from to Needs Triage.
Dan.mulholland updated the task description. (Show Details)
Dan.mulholland added a project: VisualEditor.
Dan.mulholland subscribed.

This is odd; there is code in VisualEditor explicitly to re-login users in this situation. Maybe there's something that doesn't work with read-locked-down wikis, perhaps?

Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

Yes, problem is on private wiki. In general I have issues with Mediawiki on account of this. I wonder how well it's been covered in any automated tests...

Interesting. I have persisted with this problem for 3-4 months.

I have mainly avoided using VisualEditor because of it or having to work around it by logging in using another window, click on "Switch to source editing" and then press save (with a number of Esc presses sometimes required to exit the Visual Editor save window)

Yesterday I installed Scribunto and Code editor and this problem no longer appears to occur. Is there a dependency here for e.g. a private wiki (or perhaps more generally)?

The only other change made recently was increasing timeouts and file sizes associated with the Special:Import and importDump.php script as detailed on the wiki pages.

And also, FWIW, the TemplateData extension

Dan.mulholland claimed this task.

MW 1.26 is now old, this information might be of use to others but is unlikely to be worth pursuing.

Jdforrester-WMF changed the task status from Resolved to Declined.Mar 23 2017, 6:38 PM

Shifting to "Declined" as we didn't actually help anyone here.