Page MenuHomePhabricator
Create Task
Maniphest T123153

Do not hardcode dialog widths to avoid cutting strings (ellipsis)
Closed, ResolvedPublic
Actions

Description

There are languages out there which have longer words. Hence make the dialog wider or break lines.

fooVE.png (804×525 px, 51 KB)

Details

SubjectRepoBranchLines +/-
Dialog: Set the 'title' attribute on the title LabelWidgetoojs/uimaster+13 -4
Customize query in gerrit

Related Objects

Event Timeline

Aklapper created this task.Jan 9 2016, 1:32 AM
Aklapper raised the priority of this task from to Needs Triage.
Aklapper updated the task description. (Show Details)
Aklapper added a project: VisualEditor.
Aklapper subscribed.
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 9 2016, 1:32 AM
Aklapper updated the task description. (Show Details)Jan 9 2016, 1:34 AM
Aklapper set Security to None.
Jdforrester-WMF edited projects, added OOUI; removed VisualEditor.Jan 26 2016, 8:14 PM
Jdforrester-WMF subscribed.

I don't think this is a good idea. Instead, we should work harder on labels to be shorter.

• Prtksxna subscribed.Feb 8 2016, 9:41 AM

@Jdforrester-WMF, How about adding a title attribute to the label. That way there is at least a way to see the full title if one really has to.

Screen Shot 2016-02-08 at 3.09.31 pm.png (151×520 px, 22 KB)

Jdforrester-WMF triaged this task as Low priority.Mar 2 2016, 2:11 AM
• Prtksxna added a comment.Mar 10 2016, 12:44 PM

We could do this simply by adding the title attribute to the Dialog's specific LabelWidget, or by making LabelWidget a TitledElement.

Both approaches are trivial, @Jdforrester-WMF, if you're alright with the solution, we can get this out.

• Prtksxna added projects: good first task, JavaScript.Mar 10 2016, 12:44 PM
Jdforrester-WMF merged a task: T128890: Buttons in save dialog leave too little space for caption.Apr 26 2016, 7:29 PM
Jdforrester-WMF added a subscriber: MaxSem.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 26 2016, 7:29 PM
Jdforrester-WMF edited projects, added Design; removed good first task.Apr 26 2016, 7:30 PM
In T123153#2106585, @Prtksxna wrote:

We could do this simply by adding the title attribute to the Dialog's specific LabelWidget, or by making LabelWidget a TitledElement.

Both approaches are trivial, @Jdforrester-WMF, if you're alright with the solution, we can get this out.

Let's do that as a start.

gerritbot subscribed.Jul 8 2016, 12:18 PM

Change 297973 had a related patch set uploaded (by Prtksxna):
Dialog: Set the 'title' attribute on the title LabelWidget

https://gerrit.wikimedia.org/r/297973

gerritbot added a project: Patch-For-Review.Jul 8 2016, 12:18 PM
• Prtksxna claimed this task.Jul 8 2016, 12:24 PM
gerritbot added a comment.Jul 8 2016, 6:59 PM

Change 297973 merged by jenkins-bot:
Dialog: Set the 'title' attribute on the title LabelWidget

https://gerrit.wikimedia.org/r/297973

Jdforrester-WMF removed a project: Patch-For-Review.Jul 8 2016, 7:13 PM
• Prtksxna added a comment.Jul 9 2016, 7:21 AM

@Aklapper Is this compromise alright?

• Prtksxna closed this task as Resolved.Jan 12 2017, 12:28 PM
Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.17.6 on the OOUI board.Jan 18 2017, 1:18 AM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.6); removed OOUI.
thiemowmde mentioned this in T285310: Remove duplicate title tooltip from dialogs.Jun 22 2021, 1:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL