Page MenuHomePhabricator
Create Task
Maniphest T123220

Remove IE8 workarounds from UploadWizard
Closed, ResolvedPublic
Actions

Description

km@km-tp ~/p/v/m/e/UploadWizard> ack IE8 --js
resources/ui/uw.ui.Wizard.js
99:			// Not using .default for ES3 support (IE8)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove ES3/IE8 hackaround for reserved wordMarkTraceurmediawiki/extensions/UploadWizardmaster+2 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Jan 11 2016, 7:06 AM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: Technical-Debt, UploadWizard.
Legoktm added subscribers: Aklapper, Legoktm, StudiesWorld.
Restricted Application added a project: Multimedia. · View Herald TranscriptJan 11 2016, 7:06 AM
Restricted Application added a subscriber: Steinsplitter. · View Herald Transcript
MarkTraceur triaged this task as Medium priority.Jan 11 2016, 2:19 PM
MarkTraceur subscribed.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptJan 11 2016, 2:19 PM
• matmarex subscribed.Jan 11 2016, 11:14 PM

Wow, we have way, way, way more than this. We still have IE 6 workarounds (like that stupid 'javascript:false' iframe).

MarkTraceur added a comment.Jan 12 2016, 4:58 PM

We could probably get rid of a lot of it by switching to use mw.Upload...though every time I think I'll try to accomplish that, it's a huge mistake and waste of time

Danny_B moved this task from Unsorted to IE8 on the Technical-Debt board.Jan 22 2016, 11:31 PM
Ricordisamoa subscribed.Jan 22 2016, 11:40 PM
Danny_B moved this task from IE8 to Needs removal on the Technical-Debt board.Jan 23 2016, 12:10 AM
• matmarex lowered the priority of this task from Medium to Low.Feb 1 2016, 5:09 PM
• matmarex added a comment.Feb 12 2016, 5:05 PM

(Related: T126763: Remove support for browsers not supporting HTML5 File API from UploadWizard.)

MarkTraceur raised the priority of this task from Low to Medium.Dec 6 2016, 3:58 PM
MarkTraceur moved this task from Untriaged to Next up on the Multimedia board.

This should be relatively fast, and not cause any issues...I believe UW removed support for <IE9 some time ago.

MarkTraceur claimed this task.Dec 6 2016, 5:02 PM
MarkTraceur moved this task from Next up to Doing on the Multimedia board.
MarkTraceur set Security to None.
gerritbot subscribed.Dec 6 2016, 5:06 PM

Change 325584 had a related patch set uploaded (by MarkTraceur):
Remove ES3/IE8 hackaround for reserved word

https://gerrit.wikimedia.org/r/325584

gerritbot added a project: Patch-For-Review.Dec 6 2016, 5:06 PM
MarkTraceur moved this task from Doing to Needs code review on the Multimedia board.Dec 6 2016, 5:06 PM
gerritbot added a comment.Dec 6 2016, 5:27 PM

Change 325584 merged by jenkins-bot:
Remove ES3/IE8 hackaround for reserved word

https://gerrit.wikimedia.org/r/325584

• matmarex closed this task as Resolved.Dec 6 2016, 5:30 PM
• matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Dec 6 2016, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits