Page MenuHomePhabricator

[Task] Remove IE8 workarounds from Wikibase
Closed, ResolvedPublic

Description

km@km-tp ~/p/v/m/e/Wikibase> ack IE8 --js
extensions/ValueView/src/jquery.valueview.Expert.js
112:		if ( !( viewPortNode.nodeType ) ) { // IE8 can't check for instanceof HTMLElement

vendor/data-values/data-types/js/lib/qunit/qunit.js
1082:			// Avoid "Member not found" error in IE8 caused by messing with window.constructor

vendor/data-values/javascript/lib/qunit/qunit.js
1018:			// Avoid "Member not found" error in IE8 caused by messing with window.constructor

vendor/data-values/javascript/lib/require/require.js
1857:                    //in IE8, node.attachEvent does not have toString()

vendor/data-values/javascript/lib/jquery/jquery.js
455:			// IE8,9 Will throw exceptions on certain host objects #9897
3827:		// IE8 returns a string for some attributes even when not present
5208:			// IE8 - Some boolean attributes are not treated correctly
5215:			// IE8 throws error here (do not put tests after this one)
5231:			// IE8 throws error here (do not put tests after this one)
8362:	 * Additionally XMLHttpRequest can be disabled in IE7/IE8 so
8998:// Remove in 2.0 - this supports IE8's panic based approach

lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
198:		// The DOM content needs to be cloned since IE8 will lose the reference to the DOM content

view/resources/wikibase/templates.js
68:		// ignore case since IE8 will convert tag names to upper case
80:		// back-references in IE8).
82:		// However, it does not work in IE8 and may cause errors for certain DOM structures in other
106:				continue; // omit white space between tag and text (IE8)
108:				// Strip line breaks inserted by IE8 that are not stripped by the regular expression
120:		// We are not interested in letter case and since IE8 is causing problems due to having
195:	 * Returns the parsed plain template. (Overridden due to IE8 returning objects instead of

Event Timeline

Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added subscribers: Aklapper, Legoktm, StudiesWorld.
thiemowmde renamed this task from Remove IE8 workarounds from Wikibase to [Task] Remove IE8 workarounds from Wikibase.Jan 11 2016, 3:13 PM
thiemowmde triaged this task as Lowest priority.
thiemowmde set Security to None.

I thought Wikibase master wanted to keep compatibility with old MediaWiki, now I see it's not the case 😃

Change 264744 had a related patch set uploaded (by Ricordisamoa):
Remove support for mutable undefined in JavaScript

https://gerrit.wikimedia.org/r/264744

None of the code lines mentioned in the tasks description are in MediaWiki-extensions-Wikibase-Repo.

Change 264744 merged by jenkins-bot:
Remove support for mutable undefined in JavaScript

https://gerrit.wikimedia.org/r/264744

Ladsgroup subscribed.

I'm proposing to pick this up in the next sprint (next weekly meeting).

[mediawiki/extensions/Wikibase@master] Remove some of IE8 hacks (wikibase/templates.js)
https://gerrit.wikimedia.org/r/392663

The only remaining piece here (from task description) would be jquery.wikibase.wbtooltip.js

Change 731092 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Wikibase@master] Remove IE8 workaround

https://gerrit.wikimedia.org/r/731092

The only remaining piece here (from task description) would be jquery.wikibase.wbtooltip.js

Created the patch for it. Once merged we can close this.

Change 731092 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove IE8 workaround

https://gerrit.wikimedia.org/r/731092

Ladsgroup claimed this task.

This is done.