Page MenuHomePhabricator

Minimize use of globals in DonationInterface
Closed, ResolvedPublic2 Story Points

Description

Core is moving away from sprinkling globals everywhere and we should too. For instance, a recent core change makes RequestContext::getMain()->getRequest() no longer use $wgRequest.

Some other globals to look at: $wgLang, $wgOut, $wgTitle, $wgScriptPath

Event Timeline

Ejegg created this task.Jan 11 2016, 6:45 PM
Ejegg claimed this task.
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added a subscriber: Ejegg.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 11 2016, 6:45 PM

Change 263402 had a related patch set uploaded (by Ejegg):
Zap more globals with fewer RequestContext::getMain calls

https://gerrit.wikimedia.org/r/263402

Ejegg set Security to None.
Ejegg edited a custom field.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Asbestos Removal 2016 board.

Change 263402 merged by jenkins-bot:
Zap more globals with fewer RequestContext::getMain calls

https://gerrit.wikimedia.org/r/263402

Ejegg closed this task as Resolved.Jan 21 2016, 9:46 PM