Page MenuHomePhabricator

Fix speed issue when doing a refund in the UI
Closed, ResolvedPublic4 Story Points

Description

This turned out to be because the civicrm contribution.getcount api was not passing in a 'return' array & hence CiviCRM was deciding to return the 'standard fields' which was adding slow joins. It would be nice to sort out those joins but for the purposes of this I instead fixed the api.

The patch is already merged into 4.7 and there are unit tests in 4.7 covering it https://gerrit.wikimedia.org/r/#/c/256241/

Details

Related Gerrit Patches:
wikimedia/fundraising/crm/civicrm : masterHack out credit note calculation

Event Timeline

Eileenmcnaughton claimed this task.
Eileenmcnaughton raised the priority of this task from to Needs Triage.
Eileenmcnaughton updated the task description. (Show Details)
Eileenmcnaughton added a subscriber: Eileenmcnaughton.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 11 2016, 10:54 PM

faster but still slow - 2 * missing indexes

civicrm_financial_item.entity_id
civicrm_contribution.creditnote_id

Change 266951 had a related patch set uploaded (by Eileen):
Hack out credit note calculation

https://gerrit.wikimedia.org/r/266951

Change 266951 merged by Ejegg:
Hack out credit note calculation

https://gerrit.wikimedia.org/r/266951

Eileenmcnaughton edited a custom field.
Eileenmcnaughton added a subscriber: MBeat33.

@MBeat33 Can you confirm that you can now update a contribution to be refunded without a big lag?

@Eileenmcnaughton, I just refunded Ingenico 3928329038 by changing the Contribution Status to Refunded, and it worked immediately. Thank you !!

Eileenmcnaughton closed this task as Resolved.Feb 16 2016, 5:55 PM

Good to hear

Change 285818 had a related patch set uploaded (by Eileen):
Hack out credit note calculation

https://gerrit.wikimedia.org/r/285818

Change 285818 merged by Eileen:
Hack out credit note calculation

https://gerrit.wikimedia.org/r/285818