Page MenuHomePhabricator
Create Task
Maniphest T123314

CentralNotice banner for Wikimania uses deprecated hideBanner
Open, Needs TriagePublic
Actions

Description

When I close the Wikimania banner, I get this following warning in the console:

Use of "hideBanner" is deprecated. Use mw.centralNotice method instead

See also

Related Objects
Search...

Event Timeline

He7d3r created this task.Jan 11 2016, 11:29 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added projects: MediaWiki-extensions-CentralNotice, JavaScript.
He7d3r subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 11 2016, 11:29 PM
Aklapper added a project: Technical-Debt.Jan 12 2016, 5:50 PM
Pcoombe closed this task as Resolved.Jan 13 2016, 1:44 PM
Pcoombe claimed this task.
Pcoombe subscribed.

Fixed (diff). In future it's probably best to just bring this up with the person who made the banner.

Aklapper renamed this task from CentraNotice banner for Wikimania uses deprecated hideBanner to CentralNotice banner for Wikimania uses deprecated hideBanner.Jan 13 2016, 4:17 PM
Aklapper set Security to None.
He7d3r added a comment.EditedJan 19 2016, 12:29 PM

Yeah, but I was not able to figure out on which page the banner was defined... =/

He7d3r added a comment.Jan 22 2016, 6:56 PM

Unfortunatelly there are too many banners to fix manually... :(
https://meta.wikimedia.org/w/index.php?title=Special%3ASearch&profile=advanced&search=2016+onclick+hideBanner+-%22mw.centralNotice.hideBanner%22&fulltext=Search&ns8=1&profile=advanced

He7d3r mentioned this in T86904: Use the appropriate content models for CentralNotice HTML, scripts and CSS.Jan 22 2016, 6:59 PM
He7d3r added a parent task: T120084: Fundraising scripts should not use global scope.Apr 3 2016, 12:11 PM
He7d3r reopened this task as Open.Jan 12 2017, 9:28 AM
He7d3r updated the task description. (Show Details)
• Jseddon subscribed.Jan 12 2017, 9:22 PM
• Jseddon moved this task from Backlog to BannerContent on the MediaWiki-extensions-CentralNotice board.Jan 27 2017, 5:20 AM
Pcoombe removed Pcoombe as the assignee of this task.Feb 23 2017, 7:54 PM
He7d3r added a comment.Jan 15 2018, 8:41 AM

This is still happening at https://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-template-wm2018scholarcfp2

He7d3r updated the task description. (Show Details)Jan 15 2018, 8:42 AM
Pcoombe added a comment.Jan 16 2018, 11:25 AM

Fixed that banner, and wm2018scholarcfp_deat.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL