Page MenuHomePhabricator

Do some clean-up on Cyberbot II's code
Closed, ResolvedPublic8 Estimated Story Points

Description

This task is to address some of the issues identified in T122227.

Execution and business logic code need to be separated, the code needs more comments and better variable names, curl code needs to be abstracted (or use a separate library) to avoid code duplication. Try to make sure the important functions are testable (i.e. self-contained functions that have well defined return values, etc.). We should probably put the business logic code in a class and make the code more object-oriented in general (for better modularity, readability, memory usage, testability, etc.). Also create a README.md with some basic documentation.

Event Timeline

kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Community-Tech.
kaldari subscribed.
kaldari set Security to None.
kaldari edited a custom field.
DannyH triaged this task as Medium priority.Jan 12 2016, 9:40 PM
kaldari updated the task description. (Show Details)

Waiting until Max checks in his newer code.

Waiting until Max checks in his newer code.

The new code is almost finished, but I have some rather random bugs popping up, that I am trying to resolve first. It bugs up on an article, but when I go to check for the problem, no bug surfaces. It's really weird.

Cyberpower678 claimed this task.

There's still no README.