Page MenuHomePhabricator
Create Task
Maniphest T123436

Add hhvm version checking
Closed, ResolvedPublic
Actions

Description

Part of T118932 and T75901, along with T119637 for the WMF cluster...

We should be implementing hhvm version checking for HHVM versions, rather than just depending on the PHP api versions inside HHVM

Details

SubjectRepoBranchLines +/-
Add HHVM version checkmediawiki/coreREL1_29+69 -24
Add HHVM version checkmediawiki/coremaster+69 -24
Add hhvm version checkmediawiki/coremaster+38 -1
HHVM 3.3.0 is ooldmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Jan 12 2016, 11:28 PM
Reedy raised the priority of this task from to Needs Triage.
Reedy updated the task description. (Show Details)
Reedy added a project: MediaWiki-General.
Reedy subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 12 2016, 11:28 PM
gerritbot subscribed.Jan 12 2016, 11:42 PM

Change 263769 had a related patch set uploaded (by Reedy):
HHVM 3.3.0 is oold

https://gerrit.wikimedia.org/r/263769

gerritbot added a project: Patch-For-Review.Jan 12 2016, 11:42 PM
gerritbot added a comment.Jan 13 2016, 12:48 AM

Change 263769 merged by jenkins-bot:
HHVM 3.3.0 is oold

https://gerrit.wikimedia.org/r/263769

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), MW-1.27-release-notes.Jan 13 2016, 1:00 AM
Reedy removed projects: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), Patch-For-Review.Jan 13 2016, 1:14 AM
Reedy set Security to None.
Ricordisamoa subscribed.Feb 24 2016, 3:43 AM
Paladox subscribed.May 22 2016, 5:09 PM
gerritbot added a comment.May 22 2016, 5:09 PM

Change 290070 had a related patch set uploaded (by Paladox):
Add hhvm version check

https://gerrit.wikimedia.org/r/290070

gerritbot added a project: Patch-For-Review.May 22 2016, 5:09 PM
Paladox edited projects, added MW-1.28-release-notes; removed MW-1.27-release-notes.Sep 11 2016, 8:48 PM
gerritbot added a comment.Sep 13 2016, 4:19 PM

Change 310342 had a related patch set uploaded (by Florianschmidtwelzow):
Add HHVM version check

https://gerrit.wikimedia.org/r/310342

gerritbot added a comment.Oct 8 2016, 10:19 PM

Change 290070 abandoned by Paladox:
Add hhvm version check

Reason:
https://gerrit.wikimedia.org/r/#/c/310342/4

https://gerrit.wikimedia.org/r/290070

gerritbot added a comment.May 20 2017, 11:43 AM

Change 310342 merged by jenkins-bot:
[mediawiki/core@master] Add HHVM version check

https://gerrit.wikimedia.org/r/310342

ReleaseTaggerBot added a project: MW-1.30-release-notes.May 20 2017, 12:00 PM
gerritbot added a comment.May 20 2017, 12:09 PM

Change 354671 had a related patch set uploaded (by Paladox; owner: Florianschmidtwelzow):
[mediawiki/core@REL1_29] Add HHVM version check

https://gerrit.wikimedia.org/r/354671

Paladox assigned this task to Florian.May 20 2017, 12:14 PM
Krinkle closed this task as Resolved.May 20 2017, 1:56 PM
Krinkle triaged this task as Medium priority.
Krinkle removed projects: MW-1.28-release-notes, Patch-For-Review.
gerritbot added a comment.May 20 2017, 1:56 PM

Change 354671 abandoned by Krinkle:
Add HHVM version check

Reason:
I don't see any particular reason for backporting this.

https://gerrit.wikimedia.org/r/354671

Krinkle edited projects, added MediaWiki-Installer; removed MediaWiki-General.May 20 2017, 2:05 PM
Reedy mentioned this in T172165: Require either PHP 7.0+ or HHVM in MW 1.31.Aug 2 2017, 10:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL