Page MenuHomePhabricator
Create Task
Maniphest T123446

Bring back the req. timeouts without cancelling the cpu timeout
Closed, ResolvedPublic
Actions

Description

Quoting @ssastry steps from irc,

  1. no req timeouts (current master after the merge); reduce cpu timeouts to a smaller value .. say 2 minutes .. restbase will retry those requests which would fail again
  2. req timeouts at 110s; they don't remove the cpu timeouts; cpu timeouts at say 2 minutes or a little higher .. restbase will not retry those requests
  3. req timeouts at 110s; we solve the problem of not having a mechanism to halt the wt2html pipeline; and cpu timeouts exist to deal with the runaway cpu computation scenario

Related Objects
Search...

Event Timeline

Arlolra created this task.Jan 13 2016, 12:25 AM
Arlolra claimed this task.
Arlolra raised the priority of this task from to Medium.
Arlolra updated the task description. (Show Details)
Arlolra added projects: Parsoid, Parsoid-Web-API.
Arlolra added a subscriber: ssastry.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2016, 12:25 AM
ssastry moved this task from Needs Triage to Next Up on the Parsoid board.Feb 1 2016, 3:51 AM
Arlolra moved this task from Next Up to Needs Triage on the Parsoid board.Apr 8 2016, 5:28 PM
Arlolra added a comment.May 5 2016, 6:18 PM

While we're at it, the cpu timeout can potentially be moved earlier in the middleware chain, so that it sets as early as possible.

Arlolra added a subtask: T110961: Error handling in Parsoid.Jul 19 2016, 8:43 PM
gerritbot subscribed.Nov 1 2017, 2:27 PM

Change 387458 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T123446: Bring back request timeouts

https://gerrit.wikimedia.org/r/387458

gerritbot added a project: Patch-For-Review.Nov 1 2017, 2:27 PM
gerritbot added a comment.Dec 19 2017, 10:09 PM

Change 387458 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T123446: Bring back request timeouts

https://gerrit.wikimedia.org/r/387458

gerritbot added a comment.Dec 19 2017, 10:18 PM

Change 387458 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T123446: Bring back request timeouts

https://gerrit.wikimedia.org/r/387458

Arlolra closed this task as Resolved.Dec 19 2017, 11:15 PM
Arlolra closed subtask T110961: Error handling in Parsoid as Resolved.Dec 20 2017, 3:25 AM
Isnit001 subscribed.Apr 9 2019, 8:04 AM

This issue is still referenced here: https://github.com/wikimedia/parsoid/blob/master/lib/api/routes.js#L152

Is the process.exit going to be removed? It's causing issues in MWOffliner

Arlolra added a comment.Apr 9 2019, 5:54 PM

Is the process.exit going to be removed? It's causing issues in MWOffliner

No, it's still used if parsoidConfig.useWorker is false. See,
https://github.com/wikimedia/parsoid/blob/master/lib/api/routes.js#L138

Can you elaborate on the issue?

Arlolra mentioned this in T110961: Error handling in Parsoid.Apr 9 2019, 5:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL