Page MenuHomePhabricator
Create Task
Maniphest T123459

Lower log level to debug for syntax errors in math tags
Closed, InvalidPublicPRODUCTION ERROR
Actions

Description

Currently trending on the mediawiki-errors dashboard in Logstash at https://logstash.wikimedia.org/#/dashboard/elasticsearch/mediawiki-errors. About 200 hits per 15 minutes.

Math:
Rendering failed. Printing error message.

Coming from regular page views for anonymous user cache misses and logged-in users alike.

At least one instance of it was caused by the presence of an EN DASH in the Math formula as part of a free text expression. It seems the parser fails when such a dash (–) is used in free text labels.

Example: https://en.wikipedia.org/wiki/Testing_and_performance_of_IC_engines

Screen Shot 2016-01-12 at 18.36.03.png (642×1 px, 130 KB)

_typemediawiki
channelMath
hostmw1240
http_methodGET
levelWARNING
messageRendering failed. Printing error message.
referrerhttps://www.google.com/
serveren.wikipedia.org
url/wiki/Testing_and_performance_of_IC_engines
wikienwiki

Was fixed by making an edit and changing the EN DASH (U+2013) to a HYPHEN (U+002D).

Math should probably be fixed to not crash on seeing an En-dash. Alternatively, if this can't or shouldn't be supported, the message level should change from WARNING to DEBUG or INFO, since it is a user error in that case, not a software error.

  • Verify that this error category (lexing error) triggers a tracking category so that editors can fix the problem.

Related Objects

Event Timeline

Krinkle created this task.Jan 13 2016, 2:42 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Regression, Math, Wikimedia-production-error.
Krinkle subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 13 2016, 2:42 AM
Krinkle updated the task description. (Show Details)Jan 13 2016, 2:43 AM
Krinkle set Security to None.
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jan 10 2017, 10:53 PM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Older on the Wikimedia-production-error board.Sep 5 2018, 2:43 AM
Krinkle edited projects, added Editing-team; removed Regression.
Physikerwelt renamed this task from [Regression] Math: "Rendering failed. Printing error message." to Lower log level to debug for syntax erros in math tags.Sep 5 2018, 3:41 AM
Physikerwelt renamed this task from Lower log level to debug for syntax erros in math tags to Lower log level to debug for syntax errors in math tags.
Physikerwelt triaged this task as Medium priority.
Physikerwelt subscribed.Sep 5 2018, 3:46 AM

@Krinkle thank you for this report. However, I can't do anything in the foreseeable future, since the math CI tests are broken T202223.

Physikerwelt updated the task description. (Show Details)Sep 5 2018, 3:48 AM
Krinkle added a comment.Nov 25 2018, 1:30 AM

@Physikerwelt The aforementioned task was marked as resolved. Does it look better now?

Pkra added a project: Texvcjs.Dec 10 2018, 8:36 PM
Pkra moved this task from Inbox to texvc on the Math board.
Pkra subscribed.Dec 10 2018, 8:43 PM

This is a texvc issue.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Aklapper moved this task from texvc to Inbox on the Math board.Jun 24 2020, 5:32 AM
Physikerwelt added a comment.Feb 4 2021, 6:40 AM

Is this still a problem?

Krinkle closed this task as Invalid.Feb 4 2021, 6:03 PM

No. Based on Logstash query on "mediawiki" dashboard, these messages do still exist and are still seen regularly, but that's fine, the underlying issue is okay and since it just records the diagnosis that a user produced invalid input, which we can't/shouldn't prevent.

What makes it fine now, is that:

  • We no longer query Logsstash for mediawiki as whole by severity level. "Level" is now considered local to an application/component channel, so it's up to Math to decide how to organise its messages. Our general monitoring and regression detection etc focus specifically on the "exception" and "error" channels only, not the "ERROR" severity across all local component diagnostic channels.
  • It seems the severity was also lowered at some point. The "Rendering failed. Printing error message." message is now seen with severity level "WARNING".
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL