Page MenuHomePhabricator
Create Task
Maniphest T123511

[Task] adapt primary sources tool to text/icon changes
Closed, ResolvedPublic
Actions

Description

The primary sources tool imitates Wikidata statements. We changed the regular interface to have icons plus text instead of only text in the toolbars. We need to adapt the primary sources tool to this change as right now it is sticking out.

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Jan 13 2016, 3:26 PM
Lydia_Pintscher raised the priority of this task from to Medium.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Wikidata-Gadgets.
Lydia_Pintscher added subscribers: Bene, gerritbot, Lydia_Pintscher and 7 others.
• Jonas added projects: good first task, patch-welcome.Jan 13 2016, 3:29 PM
• Jonas set Security to None.
Sjoerddebruin moved this task from incoming to monitoring on the Wikidata board.Jan 27 2016, 5:25 PM
Sjoerddebruin merged a task: T121234: [Task] adapt primary sources tool to icon change.Jan 27 2016, 5:27 PM
Sjoerddebruin added subscribers: Sjoerddebruin, StudiesWorld.
inyono added a subscriber: inyono.Mar 1 2016, 1:10 PM

Should be solved by https://www.wikidata.org/wiki/User:Inyono/freebase2wikidata.js (starting point: https://www.wikidata.org/wiki/User:Tomayac/freebase2wikidata.js). Not sure how to submit the changes, though.

Ricordisamoa added a comment.Mar 1 2016, 1:18 PM
In T123511#2075517, @inyono wrote:

Not sure how to submit the changes, though.

Have you seen https://github.com/google/primarysources/blob/master/frontend/freebase2wikidata.js

inyono claimed this task.Mar 1 2016, 1:30 PM

Thanks for the link. I created a Pull Request: https://github.com/google/primarysources/pull/80

Tomayac added a subscriber: Tomayac.Mar 1 2016, 1:33 PM

Perfect, thanks for the Pull Request. Merging now! Could any of the admins deploy the gadget?

Sjoerddebruin added a comment.Mar 1 2016, 1:36 PM
In T123511#2075563, @Tomayac wrote:

Perfect, thanks for the Pull Request. Merging now! Could any of the admins deploy the gadget?

Done.

inyono closed this task as Resolved.Mar 1 2016, 1:38 PM
Sjoerddebruin added a comment.Mar 1 2016, 1:49 PM

Ehm, I think the links in the reference section also needs to be adjusted.

inyono reopened this task as Open.Mar 1 2016, 2:45 PM

my bad, I missed that: https://github.com/google/primarysources/pull/81

thiemowmde removed a subscriber: thiemowmde.Mar 1 2016, 3:14 PM
Tobi_WMDE_SW closed this task as Resolved.Mar 1 2016, 4:14 PM

Change is merged.

Lydia_Pintscher added a comment.Mar 1 2016, 5:18 PM

Thanks a lot, @inyono!

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL