When the app is using RESTBase, some links open the gallery, even though they should just open another page.
The reason for that is that these links have the class="image" attribute set. Let's remove that since we don't need it.
Example: http://localhost:6927/en.wikipedia.org/v1/page/mobile-sections-lead/Masoretic%20text
<figcaption>The <a href=\"/wiki/Nash_Papyrus\" class=\"image\">Nash Papyrus</a>
Change 263888 had a related patch set uploaded (by BearND):
Remove class=image attribute from image links
Looks good to me. As an aside, the wiki page links have a visible "w:" prefix which I think is intentional.
This appears to still exist and is causing a couple crashes in the Android app. Here's one case[0]:
The gallery opens because the link class is "image" and there a couple silent crashes in the log. Attempting to share crashes the app for real.
I think there are a couple other issues[1,2] that can arise because the API assumptions become incorrect when trying to obtain image info for a non-image.
[0] https://rink.hockeyapp.net/manage/apps/226649/app_versions/17/crash_reasons/120961037?type=overview
[1] https://rink.hockeyapp.net/manage/apps/226649/app_versions/17/crash_reasons/120992191
[2] https://rink.hockeyapp.net/manage/apps/226649/app_versions/17/crash_reasons/120991565
@Mholloway, I agree. It's one of our top crashes in terms of number of users affected. I'm happy to fix this but it looks like @bearND is currently on it.
Change 292212 had a related patch set uploaded (by Dbrant):
Fix insertion of 'image' class into figure links.
Change 292212 merged by jenkins-bot:
Fix insertion of 'image' class into figure links.
I guess we'll need to ask @mobrovac to regenerate /mobile-sections* again for all of the wikipedias for this since it's causing crashes.
Or, we can narrow it to pages where var regex = new RegExp('<figcaption.*<a.*class="image".*>.*</figcaption>', 'g'); and
lead.sections.filter(function(section) { return regex.test(section.text); }).length
|| remaining.sections.filter(function(section) { return regex.test(section.text); }).lengthif that is possible/helps.
We could also use a CSS selector if it's easier: Something like "figure a, span[typeof^=mw:Image] a.image" should cover it.