GeoData code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Jan 13 2016, 7:11 PM

Description

Ever since https://gerrit.wikimedia.org/r/#/c/263616/ the Math repo has been un-mergeable in CI, needing forced-pushes. This is totally not OK. Please fix it immediately, or we will have to revert the repo to last known good code.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Do not return null reference in JobQueueMemory	mediawiki/core	master	+32 -2

Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Jan 13 2016, 7:11 PM

Jdforrester-WMF raised the priority of this task from to Unbreak Now!.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: Wikidata, Math, Contributors-Team.

Jdforrester-WMF added subscribers: Jdforrester-WMF, thiemowmde, Physikerwelt, Esanders.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2016, 7:11 PM

greg subscribed.Jan 13 2016, 7:12 PM

Lydia_Pintscher added subscribers: Lydia_Pintscher, hoo, aude.Jan 13 2016, 7:20 PM

I think the problem was in the GeoData code (with the database updates), but has since been fixed:

https://gerrit.wikimedia.org/r/#/c/263876/

jenkins now approves of patches in Math extension (e.g. https://gerrit.wikimedia.org/r/#/c/263781/)

Aha, thank you.

Jdforrester-WMF renamed this task from Fix or remove the Wikidata/Math code to Fix or remove the Wikidata/Math/GeoData code.Jan 13 2016, 8:03 PM

Jdforrester-WMF reassigned this task from Jdforrester-WMF to aude.

Jdforrester-WMF added projects: GeoData, MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).

Jdforrester-WMF set Security to None.

cf https://gerrit.wikimedia.org/r/#/c/264062/
10:17:15 1) Wikibase\Client\Test\Usage\UsageTrackingIntegrationTest::testUpdateUsageOnCreation
10:17:15 Only variable references should be returned by reference