Page MenuHomePhabricator

Fix or remove the Wikidata/Math/GeoData code
Closed, ResolvedPublic

Description

Ever since https://gerrit.wikimedia.org/r/#/c/263616/ the Math repo has been un-mergeable in CI, needing forced-pushes. This is totally not OK. Please fix it immediately, or we will have to revert the repo to last known good code.

Event Timeline

Jdforrester-WMF raised the priority of this task from to Unbreak Now!.
Jdforrester-WMF updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2016, 7:11 PM
greg added a subscriber: greg.Jan 13 2016, 7:12 PM
aude added a comment.Jan 13 2016, 7:52 PM

I think the problem was in the GeoData code (with the database updates), but has since been fixed:

https://gerrit.wikimedia.org/r/#/c/263876/

jenkins now approves of patches in Math extension (e.g. https://gerrit.wikimedia.org/r/#/c/263781/)

Jdforrester-WMF closed this task as Resolved.Jan 13 2016, 8:03 PM
Jdforrester-WMF claimed this task.

Aha, thank you.

Jdforrester-WMF renamed this task from Fix or remove the Wikidata/Math code to Fix or remove the Wikidata/Math/GeoData code.Jan 13 2016, 8:03 PM
Jdforrester-WMF reassigned this task from Jdforrester-WMF to aude.
Jdforrester-WMF set Security to None.
Physikerwelt reopened this task as Open.Jan 14 2016, 11:03 AM

cf https://gerrit.wikimedia.org/r/#/c/264062/
10:17:15 1) Wikibase\Client\Test\Usage\UsageTrackingIntegrationTest::testUpdateUsageOnCreation
10:17:15 Only variable references should be returned by reference

Unrelated bug in code that was introduced today, fixed in https://gerrit.wikimedia.org/r/264067.

Change 264067 had a related patch set uploaded (by Physikerwelt):
Do not return null reference in JobQueueMemory

https://gerrit.wikimedia.org/r/264067

Change 264067 merged by jenkins-bot:
Do not return null reference in JobQueueMemory

https://gerrit.wikimedia.org/r/264067