Page MenuHomePhabricator
Create Task
Maniphest T123775

Keyboard shortcuts dialog has no scroll bar
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Easy steps to reproduce:

  1. Shorten your web browser window so that only a few lines are visible.
  2. Open a page in VisualEditor.
  3. Open the keyboard shortcuts "dialog" box in the (?) Help menu.
  4. Try to scroll.

Originally reported in User agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.152 Safari/537.36 and confirmed in Safari 9/Mac OS 10.10.5

We used to have scroll bars in this dialog (e.g., per T92723: Keyboard shortcuts dialog should be vertically scrollable, not horizontally scrollable ), so presumably this is a regression.

Details

SubjectRepoBranchLines +/-
Dialog: Don't set overflow:hidden; on .oo-ui-window-body elementsoojs/uimaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Jan 15 2016, 7:33 PM
• Whatamidoing-WMF raised the priority of this task from to Needs Triage.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added a project: VisualEditor-MediaWiki.
• Whatamidoing-WMF subscribed.
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 15 2016, 7:33 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Krenair added subscribers: Krenair, • TrevorParscal.Jan 15 2016, 8:00 PM

I believe this is related to the overflow changes in https://gerrit.wikimedia.org/r/#/c/146296/5/src/themes/agora/Dialog.less

Krenair added a project: OOUI.Jan 15 2016, 8:00 PM
gerritbot subscribed.Jan 15 2016, 8:03 PM

Change 264326 had a related patch set uploaded (by Alex Monk):
Don't set overflow:hide; on oo-ui-window-body elements inside dialogs

https://gerrit.wikimedia.org/r/264326

gerritbot added a project: Patch-For-Review.Jan 15 2016, 8:03 PM
Kipod subscribed.Jan 16 2016, 3:58 AM

also: hotkeys help form is completely borked in hebrew, probably in all other RTL languages.

peace.

Krenair added a comment.Jan 18 2016, 6:21 PM
In T123775#1938815, @Kipod wrote:

also: [...]

please use a separate task, this is about scroll bars

• Elitre subscribed.Jan 22 2016, 11:37 AM
gerritbot added a comment.Jan 25 2016, 2:58 PM

Change 264326 merged by jenkins-bot:
Dialog: Don't set overflow:hidden; on .oo-ui-window-body elements

https://gerrit.wikimedia.org/r/264326

Krenair closed this task as Resolved.Jan 25 2016, 3:12 PM
Krenair claimed this task.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.Jan 25 2016, 4:34 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.15.1), MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)); removed OOjs-UI-next-release.Jan 27 2016, 12:51 AM
Jdforrester-WMF triaged this task as Medium priority.Jan 27 2016, 12:52 AM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jan 29 2016, 4:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL