Page MenuHomePhabricator
Create Task
Maniphest T123821

[Regression] Invalid or virtual namespace -1 given.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Trending error since 1.27.0-wmf10 hit wikipedias (2016-01-14T12:02:44)

{
  "_index": "logstash-2016.01.14",
  "_type": "mediawiki",
  "_id": "AVJCJ69EptxhN1XaTUMd",
  "_score": null,
  "_source": {
    "message": "Invalid or virtual namespace -1 given.",
    "@version": 1,
    "@timestamp": "2016-01-14Txx:xx:xx",
    "type": "mediawiki",
    "host": "mw1199",
    "level": "ERROR",
    "tags": [
      "syslog",
      "es",
      "es",
      "exception-json",
      "normalized_message_untrimmed"
    ],
    "channel": "exception",
    "url": "/w/api.php?action=mobileview&format=json&page=File%3AWinters_bone_poster.jpg&prop=text%7Csections%7Clastmodified%7Cnormalizedtitle%7Cdisplaytitle%7Cprotection%7Ceditable&onlyrequestedsections=1&sections=0&sectionprop=toclevel%7Cline%7Canchor&noheadings=true&appInstallID=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
    "ip": "xxx.xxx.xxx.xxx",
    "http_method": "GET",
    "server": "en.wikipedia.org",
    "referrer": null,
    "uid": "658f8d0",
    "process_id": 3913,
    "wiki": "enwiki",
    "private": true,
    "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/page/WikiPage.php",
    "line": 111,
    "code": 0,
    "backtrace": [
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/context/RequestContext.php",
        "line": 254,
        "function": "factory",
        "class": "WikiPage",
        "type": "::",
        "args": [
          "Title"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/context/DerivativeContext.php",
        "line": 221,
        "function": "getWikiPage",
        "class": "RequestContext",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/context/DerivativeContext.php",
        "line": 221,
        "function": "getWikiPage",
        "class": "DerivativeContext",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/context/ContextSource.php",
        "line": 112,
        "function": "getWikiPage",
        "class": "DerivativeContext",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/extensions/MobileFrontend/includes/MobileFrontend.body.php",
        "line": 48,
        "function": "getWikiPage",
        "class": "ContextSource",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/extensions/MobileFrontend/includes/MobileFrontend.hooks.php",
        "line": 1118,
        "function": "DOMParse",
        "class": "ExtMobileFrontend",
        "type": "::",
        "args": [
          "OutputPage",
          "string",
          "boolean"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/Hooks.php",
        "line": 195,
        "function": "onOutputPageParserOutput",
        "class": "MobileFrontendHooks",
        "type": "::",
        "args": [
          "OutputPage",
          "ParserOutput"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/OutputPage.php",
        "line": 1816,
        "function": "run",
        "class": "Hooks",
        "type": "::",
        "args": [
          "string",
          "array"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/OutputPage.php",
        "line": 1854,
        "function": "addParserOutputMetadata",
        "class": "OutputPage",
        "type": "->",
        "args": [
          "ParserOutput"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/OutputPage.php",
        "line": 1743,
        "function": "addParserOutput",
        "class": "OutputPage",
        "type": "->",
        "args": [
          "ParserOutput"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/OutputPage.php",
        "line": 1681,
        "function": "addWikiTextTitle",
        "class": "OutputPage",
        "type": "->",
        "args": [
          "string",
          "Title",
          "boolean",
          "boolean",
          "boolean"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/page/ImagePage.php",
        "line": 553,
        "function": "addWikiText",
        "class": "OutputPage",
        "type": "->",
        "args": [
          "string"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/page/ImagePage.php",
        "line": 154,
        "function": "openShowImage",
        "class": "ImagePage",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/extensions/MobileFrontend/includes/api/ApiMobileView.php",
        "line": 620,
        "function": "view",
        "class": "ImagePage",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/extensions/MobileFrontend/includes/api/ApiMobileView.php",
        "line": 507,
        "function": "getFilePage",
        "class": "ApiMobileView",
        "type": "->",
        "args": [
          "Title"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/extensions/MobileFrontend/includes/api/ApiMobileView.php",
        "line": 90,
        "function": "getData",
        "class": "ApiMobileView",
        "type": "->",
        "args": [
          "Title",
          "boolean"
        ]
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/api/ApiMain.php",
        "line": 1308,
        "function": "execute",
        "class": "ApiMobileView",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/api/ApiMain.php",
        "line": 460,
        "function": "executeAction",
        "class": "ApiMain",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/includes/api/ApiMain.php",
        "line": 432,
        "function": "executeActionWithErrorHandling",
        "class": "ApiMain",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/php-1.27.0-wmf.10/api.php",
        "line": 83,
        "function": "execute",
        "class": "ApiMain",
        "type": "->",
        "args": []
      },
      {
        "file": "/srv/mediawiki/w/api.php",
        "line": 3,
        "function": "include",
        "args": [
          "string"
        ]
      }
    ],
    "exception_id": "ac3eb5ee",
    "class": "mediawiki",
    "message_checksum": "b655bbe6d238d5ef851671a3cd06d47d",
    "normalized_message": "Invalid or virtual namespace -1 given."
  },
  "sort": [
    1452808842000
  ]
}

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendwmf/1.27.0-wmf.10+10 -0Set the wiki page on the derivative request
mediawiki/extensions/MobileFrontendmaster+10 -0Set the wiki page on the derivative request
Customize query in gerrit

Related Objects

Event Timeline

• bd808 created this task.Jan 16 2016, 1:47 AM
• bd808 raised the priority of this task from to Needs Triage.
• bd808 updated the task description. (Show Details)
• bd808 added projects: Wikimedia-production-error, MediaWiki-Action-API, MobileFrontend, Wikipedia-iOS-App-Backlog.
• bd808 changed the visibility from "Public (No Login Required)" to "WMF-NDA (Project)".
• bd808 changed the edit policy from "All Users" to "WMF-NDA (Project)".
• bd808 added a subscriber: • bd808.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2016, 1:47 AM
Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Jan 16 2016, 1:51 AM
• bd808 changed the visibility from "WMF-NDA (Project)" to "Public (No Login Required)".Jan 18 2016, 4:30 PM
• bd808 changed the edit policy from "WMF-NDA (Project)" to "All Users".
• bd808 set Security to None.
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 18 2016, 4:30 PM
• bd808 added a subscriber: Anomie.Jan 18 2016, 4:30 PM
@Anomie wrote:

I can reproduce it by hitting https://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&page=File%3AWinters_bone_poster.jpg&prop=text|sections|lastmodified|normalizedtitle|displaytitle|protection|editable&onlyrequestedsections=1&sections=0&sectionprop=toclevel|line|anchor&noheadings=true. It needs to be having "shouldDisplayMobileView()" return true.

This is mostly educated guess, but I suspect that what's going on is that https://gerrit.wikimedia.org/r/#/c/243227/ made MobileFrontend start calling OutputPage::getWikiPage() from inside the code path via the "HACK HACK HACK" in ApiMobileView::getFilePage(). That hack doesn't set the WikiPage on the context, and DerivativeContext::getWikiPage() falls up to its parent's getWikiPage() instead of calling WikiPage::factory( $this->getTitle() ). Once it gets to the RequestContext::getWikiPage() to actually construct a WikiPage, it uses the RequestContext's Title instead of the one set on the DerivativeContext by the hack. And that Title would be "Special:Badtitle/dummy title for API calls set in api.php", hence the namespace -1 in the error message.

phuedx added a project: Reading-Web-Sprint-64-Five Sprints at Freddy's.Jan 18 2016, 4:49 PM
phuedx added a subscriber: phuedx.

I've moved this into our next sprint just prior to kickoff so that we can talk about it.

phuedx renamed this task from Invalid or virtual namespace -1 given. to [Regression] Invalid or virtual namespace -1 given..Jan 18 2016, 5:37 PM
phuedx moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-64-Five Sprints at Freddy's board.
• Jhernandez triaged this task as High priority.Jan 18 2016, 6:16 PM
• Jhernandez added a subscriber: • Jhernandez.

Since it is on the sprint, High

phuedx claimed this task.Jan 19 2016, 12:03 PM
phuedx moved this task from To Do to Doing on the Reading-Web-Sprint-64-Five Sprints at Freddy's board.
gerritbot added a subscriber: gerritbot.Jan 19 2016, 1:57 PM

Change 264947 had a related patch set uploaded (by Phuedx):
Set the wiki page on the derivative request

https://gerrit.wikimedia.org/r/264947

gerritbot added a project: Patch-For-Review.Jan 19 2016, 1:57 PM
phuedx moved this task from Doing to Code Review on the Reading-Web-Sprint-64-Five Sprints at Freddy's board.Jan 19 2016, 1:59 PM
Florian added a subscriber: Florian.Jan 19 2016, 2:07 PM
Florian added a comment.Jan 19 2016, 2:15 PM

Copy my comments from gerrit, to be dicussed here (which seems to be a better place in my opinion):

Just a quick look: The better question is, why RequestContext::canUseWikiPage() returns true. This is used to make sure, that RequestContext::getWikiPage() can be used without throwing an error and is correctly called before using it[1]. I think the change makes sense and I will merge it, after I had the chance to test it. However, it would be nice to track down my note, too, to make sure, this isn't an error which might come back later :)

Btw.: RequestContext::canUseWikiPage() used $title->canExists() as far as I know (haven't had the time to check, yet). And if ApiMain sets the title to a special page, the Title::canExists() function should return false.

[1] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.body.php#L47

Ah, wait, it seems, that DerivativeContext uses the title, which is set by the function's hack, and only if it wasn't set, uses the RequestContext title[1]. The DerivativeContext::getWikiPage on the other hand, uses the RequestContext instance directly without using the title set to the DerivativeContext[2]. In my point of view, this should be a bug in mediawiki/core, too, because of O set a title to a derivative context, I would assume, that it's used for any function, that involves the title, too. Like getWikiPage().

[1] https://github.com/wikimedia/mediawiki/blob/master/includes/context/DerivativeContext.php#L188-L196 [2] https://github.com/wikimedia/mediawiki/blob/master/includes/context/DerivativeContext.php#L217-L223

• BGerstle-WMF added a subscriber: • BGerstle-WMF.Jan 19 2016, 3:16 PM

What can the iOS team do (if anything) to help address the issue? If it's not a client-side issue, is it alright if I remove this from our backlog?

phuedx added a comment.Jan 19 2016, 4:05 PM
In T123821#1944016, @BGerstle-WMF wrote:

What can the iOS team do (if anything) to help address the issue? If it's not a client-side issue, is it alright if I remove this from our backlog?

This is an issue with ApiMobileView in MobileFrontend and possibly, as @Florian mentions above, in core. You can safely remove it from your backlog.

• BGerstle-WMF removed a project: Wikipedia-iOS-App-Backlog.Jan 19 2016, 4:06 PM
phuedx added a comment.Jan 19 2016, 4:15 PM
In T123821#1943904, @Florian wrote:

Ah, wait, it seems, that DerivativeContext uses the title, which is set by the function's hack, and only if it wasn't set, uses the RequestContext title[1]. The DerivativeContext::getWikiPage on the other hand, uses the RequestContext instance directly without using the title set to the DerivativeContext[2]. In my point of view, this should be a bug in mediawiki/core, too, because of O set a title to a derivative context, I would assume, that it's used for any function, that involves the title, too. Like getWikiPage().

[1] https://github.com/wikimedia/mediawiki/blob/master/includes/context/DerivativeContext.php#L188-L196 [2] https://github.com/wikimedia/mediawiki/blob/master/includes/context/DerivativeContext.php#L217-L223

I think you're correct about DerivativeContext#getWikiPage (and all Title-related functions) using the Title set by #setTitle. I'd prefer to stop the exception being thrown first, remove the ApiMobileView#getFilePage method second (it's a "HACK: HACK: HACK:"), and fix up the behaviour of DerivativeContext third.

gerritbot added a comment.Jan 19 2016, 4:48 PM

Change 264947 merged by jenkins-bot:
Set the wiki page on the derivative request

https://gerrit.wikimedia.org/r/264947

Florian added a comment.Jan 19 2016, 4:55 PM

I'll opened T124060: DerivativeContext should use the Title set for methods where a Title object is used instead of the one of RequestContext for the DerivativeContext thing.

Florian mentioned this in T124060: DerivativeContext should use the Title set for methods where a Title object is used instead of the one of RequestContext.Jan 19 2016, 4:55 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 19 2016, 5:00 PM
Florian closed this task as Resolved.Jan 19 2016, 5:37 PM
Florian removed a project: Patch-For-Review.
gerritbot added a comment.Jan 19 2016, 5:46 PM

Change 264973 had a related patch set uploaded (by BryanDavis):
Set the wiki page on the derivative request

https://gerrit.wikimedia.org/r/264973

gerritbot added a project: Patch-For-Review.Jan 19 2016, 5:46 PM
• BGerstle-WMF removed a subscriber: • BGerstle-WMF.Jan 19 2016, 6:03 PM
gerritbot added a comment.Jan 20 2016, 12:46 AM

Change 264973 merged by jenkins-bot:
Set the wiki page on the derivative request

https://gerrit.wikimedia.org/r/264973

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 20 2016, 1:01 AM
phuedx moved this task from Code Review to Done on the Reading-Web-Sprint-64-Five Sprints at Freddy's board.Jan 20 2016, 11:13 AM
demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Mar 11 2016, 11:58 PM
Pppery removed projects: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review.Jan 3 2018, 3:52 AM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL