Page MenuHomePhabricator
Create Task
Maniphest T123849

Transcodes in formats removed from $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet not automatically removed
Closed, DeclinedPublic
Actions

Description

Steps to Reproduce

  • Download and install timedmediahandler and mwembed

Actual Results

  • When you go to a video on your wiki and you change the setting in TimedMediaHandler.php it dosent change anything you can still view the video in that format.

Expected Results

  • Go to TimedMediaHandler.php file then go to setting $wgEnabledTranscodeSet then remove all off OGV_X settings.

Then go to a video for example File:FEZ trial gameplay HD.webm on your wiki then try using internet explorer.

ogv format should not show but it does.

Please fix this.

This may be a reason why in extension.json it wont work if over written in localsettings.php or wont turn it off.

There also needs support to change the default by doing false or true for that specific format.

**

Details

SubjectRepoBranchLines +/-
Remove transcodes that are no longer enabledmediawiki/extensions/TimedMediaHandlermaster+16 -3
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedJdforrester-WMFT87981 Convert TimedMediaHandler to use extension registration
DeclinedNoneT123849 Transcodes in formats removed from $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet not automatically removed
· · ·

Event Timeline

Paladox created this task.Jan 16 2016, 11:38 PM
Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a project: TimedMediaHandler.
Paladox subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 16 2016, 11:38 PM
Paladox added subscribers: • brion, TheDJ.Jan 17 2016, 10:15 AM

@brion and @TheDJ can I add you to task please.

Paladox set Security to None.Jan 17 2016, 10:15 AM
Paladox removed subscribers: TheDJ, • brion.
Paladox added a comment.Jan 17 2016, 11:06 AM

Even removing public static $derivativeSettings stuff in it and the stuff still shows. Meaning that something isent being controlled properly meaning it is doing it anys ways without the settings overriding it.

Please fix this.

Paladox added a comment.Jan 17 2016, 11:06 AM

Can I set this as high priority since the settings is broken making it use less so the setting needs fixing.

Paladox added a comment.Jan 17 2016, 11:30 AM

Maybe caching could be the problem. Since I try removing the messages from en.json but they still shows on the video even when refreshing.

• brion triaged this task as Lowest priority.Jan 18 2016, 7:19 PM
• brion subscribed.

Old transcodes aren't automatically removed. You can re-run them to remove.

• brion renamed this task from $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet settings do not work to Transcodes in formats removed from $wgEnabledTranscodeSet and $wgEnabledAudioTranscodeSet not automatically removed.Jan 18 2016, 7:20 PM
Paladox added a comment.Jan 18 2016, 7:29 PM

@brion I use it on my local site that uses the transcodes from commons and when I remove them they should not show as an option when playing the video in that format.

Paladox added a comment.Jan 18 2016, 7:31 PM

Meaning the transcodes can stay there they just carnt be played in the player.

Paladox added a subscriber: TheDJ.Feb 18 2016, 2:57 PM

@TheDJ this config is broken since all transcodes work no matter what. What we could convert it to also support strings so like an if statement with || so that way we can use either way to get that transcode to work but config still blocks everything.

TheDJ added a parent task: T87981: Convert TimedMediaHandler to use extension registration.Feb 18 2016, 3:17 PM
Paladox added a comment.Feb 18 2016, 9:30 PM

@TheDJ and @brion ive found the problem. It is in mw.PlayerControlBuilder.js file.

The function is getSwitchSourceMenu: function(){

and problem code is var icon = ( source.getSrc() == embedPlayer.mediaElement.selectedSource.getSrc() ) ? 'bullet' : 'radio-on';

So regardless of our config that var will alway overide it since it is finding the source of the file and displaying it. It isent going through a setup when only the sources specified in the config are shown.

Paladox added a comment.Feb 18 2016, 9:38 PM

Actually it is not that function it is getHtmlMediaTagOutput in TimedMediaTransformOutput.php.

gerritbot subscribed.Apr 19 2016, 10:18 PM

Change 284368 had a related patch set uploaded (by TheDJ):
Remove transcodes that are no longer enabled

https://gerrit.wikimedia.org/r/284368

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 10:18 PM
gerritbot added a project: Patch-For-Review.Apr 19 2016, 10:18 PM
Paladox added a comment.EditedApr 19 2016, 10:36 PM

@TheDJ Would this https://gerrit.wikimedia.org/r/284368 also work for example if you are watching a commons videos on another wiki such as your own wiki would that work or would it show the videos that are not even specified in your config unless changed Wikimedia side.

And thanks for working on this.

TheDJ moved this task from To sort to Doing on the TimedMediaHandler board.Apr 19 2016, 11:49 PM
gerritbot added a comment.Aug 10 2017, 10:19 PM

Change 284368 abandoned by TheDJ:
Remove transcodes that are no longer enabled

https://gerrit.wikimedia.org/r/284368

• brion closed this task as Declined.Jan 9 2018, 9:47 PM

I recommend using cleanupTranscodes.php to remove old files rather than trying to auto-remove them, as there may be race conditions, or a need to revert a change, etc.

Closing as declined, though now there's a way to clean them up manually. :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL