T85385: Implement "Monolingual text" in Pywikibot was merged without tests.
Tests are needed to remove corner cases in the new code, and prevent regressions in the future.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add edit tests for WbMonolingualText | pywikibot/core | master | +57 -2 | |
| Add tests for Wikibase Monolingual text | pywikibot/core | master | +32 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Smalyshev | T85385 Implement "Monolingual text" in Pywikibot | |||
| Resolved | Lokal_Profil | T123856 Add tests for Wikibase Monolingual text | |||
| Resolved | Xqt | T129276 test_WbMonolingualText_invalid_text failing |
Event Timeline
Comment Actions
I can take this one.
What I thought of so far was:
- basic creation from a string
- creation from a unicode string
- equality
- fromWikibase-toWikibase roundtrip
I would also add raising errors if either parameter is an empty string or not a basestring, then test that these are raised.
Anything else of the top of anyone's mind?
Comment Actions
Change 264739 had a related patch set uploaded (by Lokal Profil):
Add tests for Wikibase Monolingual text
Comment Actions
Also need an edit failure test (in tests/edit_failure_tests.py) for trying to save an invalid language; so we can document the error raised.
Comment Actions
Change 264935 had a related patch set uploaded (by Lokal Profil):
Add edit tests for WbMonolingualText