Page MenuHomePhabricator
Create Task
Maniphest T123935

Use CheckboxMultiSelectWidget (when it exists) in HTMLMultiSelectField
Closed, ResolvedPublic
Actions

Description

Use CheckboxMultiSelectWidget (when it exists) in HTMLMultiSelectField. We wouldn't need custom style overrides then (like a8ae2208cec8914028ce260c1b2f00a92e7e2127).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
HTMLForm: Properly support 'flatlist' in OOUI modemediawiki/coremaster+7 -10
HTMLMultiSelectField: Use CheckboxMultiselectInputWidgetmediawiki/coremaster+33 -19
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedVolker_ET117781 Convert Special:Preferences to OOUI
ResolvedTchandersT117884 Convert Special:UserRights to HTMLForm
ResolvedmatmarexT123935 Use CheckboxMultiSelectWidget (when it exists) in HTMLMultiSelectField
ResolvedmatmarexT117782 Implement CheckboxMultiselectWidget (and CheckboxMultiselectInputWidget)
· · ·

Event Timeline

matmarex created this task.Jan 18 2016, 4:26 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added projects: MediaWiki-HTMLForm, Technical-Debt.
matmarex added subscribers: matmarex, Jdforrester-WMF.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 18 2016, 4:26 PM
matmarex added a subtask: T117782: Implement CheckboxMultiselectWidget (and CheckboxMultiselectInputWidget).Jan 18 2016, 4:26 PM
Jdforrester-WMF triaged this task as Medium priority.Jan 18 2016, 4:33 PM
Jdforrester-WMF set Security to None.
matmarex claimed this task.May 30 2016, 11:51 AM
gerritbot subscribed.May 30 2016, 11:54 AM

Change 291714 had a related patch set uploaded (by Bartosz Dziewoński):
HTMLMultiSelectField: Use CheckboxMultiselectInputWidget

https://gerrit.wikimedia.org/r/291714

gerritbot added a project: Patch-For-Review.May 30 2016, 11:54 AM
matmarex added a parent task: T117781: Convert Special:Preferences to OOUI.May 30 2016, 1:12 PM
matmarex added a parent task: T117884: Convert Special:UserRights to HTMLForm.
Jdforrester-WMF closed subtask T117782: Implement CheckboxMultiselectWidget (and CheckboxMultiselectInputWidget) as Resolved.May 30 2016, 5:12 PM
gerritbot added a comment.May 31 2016, 10:56 PM

Change 291714 merged by jenkins-bot:
HTMLMultiSelectField: Use CheckboxMultiselectInputWidget

https://gerrit.wikimedia.org/r/291714

Jdforrester-WMF closed this task as Resolved.May 31 2016, 11:05 PM
Jdforrester-WMF removed a project: Patch-For-Review.
ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), MW-1.28-release-notes.Jun 1 2016, 3:01 AM
Sethakill reopened this task as Open.Jun 5 2016, 7:58 AM
Sethakill subscribed.

This change will broke pages with this field and flatlist parameter.

wmf.4master
T123935 wmf.4.png (750×1 px, 112 KB)
T123935 master.png (750×1 px, 76 KB)
matmarex added a comment.Jun 6 2016, 3:28 PM

Thank you for spotting this!

gerritbot added a comment.Jun 6 2016, 3:29 PM

Change 292947 had a related patch set uploaded (by Bartosz Dziewoński):
HTMLForm: Properly support 'flatlist' in OOUI mode

https://gerrit.wikimedia.org/r/292947

gerritbot added a project: Patch-For-Review.Jun 6 2016, 3:29 PM
gerritbot added a comment.Jun 6 2016, 3:40 PM

Change 292947 merged by jenkins-bot:
HTMLForm: Properly support 'flatlist' in OOUI mode

https://gerrit.wikimedia.org/r/292947

Sethakill closed this task as Resolved.Jun 6 2016, 3:42 PM
Sethakill removed a project: Patch-For-Review.
Sethakill removed a subscriber: gerritbot.
Jdforrester-WMF added a comment.Jun 6 2016, 3:54 PM

Updated screenshot for those who are interested:

Screen Shot 2016-06-06 at 16.49.41.png (479×1 px, 56 KB)

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 8 2016, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits