Page MenuHomePhabricator

VisualEditor find-and-replace should use the Tab key to move from the Find input to the Replace input
Closed, ResolvedPublic1 Estimated Story Points

Description

  1. Invoke VisualEditor's "Find and replace" command from the menu
  2. Enter a search string in the "Find" text input
  3. Press the Tab key

The expected action is to change focus to the "Replace" text input, like most other editors in the world. But instead, focus goes to the wiki search box. I suggest changing this so the focus goes to "Replace".

Event Timeline

maiden_taiwan raised the priority of this task from to Needs Triage.
maiden_taiwan updated the task description. (Show Details)
maiden_taiwan added a project: VisualEditor.
maiden_taiwan subscribed.

This is in VisualEditor 0.1.0 on MediaWiki 1.26.2.

Press tab a second time and it goes to the replace box. Sadly this is because Vector's search widget inserts itself into the tab order; in standalone VE this works perfectly.

Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Sadly indeed. Should this be considered a bug in Vector?

Change 274453 had a related patch set uploaded (by DLynch):
FindAndReplaceDialog: don't use tabindex

https://gerrit.wikimedia.org/r/274453

@maiden_taiwan Only to the extent that using tabindex > 0 anywhere is kind of a bug, because it's not scopeable and so collisions are basically guaranteed.

Change 274453 merged by jenkins-bot:
FindAndReplaceDialog: don't use tabindex

https://gerrit.wikimedia.org/r/274453