Page MenuHomePhabricator

[Phragile] Fork custom libphutil to wmde namespace and load from there
Closed, ResolvedPublic2 Estimated Story Points

Description

atm hosted here https://github.com/jakobw/libphutil.

Should be wmde namspace with wmde-dev permissions. Composer file needs to be updated as well then.

Think about versioning the lib and how.

Event Timeline

WMDE-Fisch raised the priority of this task from to Needs Triage.
WMDE-Fisch updated the task description. (Show Details)

Do we want to fork it or move it?
Forking it would mean it has that stupid fork symbol on github for ever! :D

I have forked the upstream into https://github.com/wmde/libphutil.
I agree with @Addshore that maintaining the fork is actually more or less the same amount of work as having a repository with upstream code + our patch, and only update it when there are changes in the upstream. I have no opinion which solution is better/cleaner. Went with fork as it was only clicking one button :) We can always change that if needed!

PR switching version used by Phragile: https://github.com/wmde/phragile/pull/193.

Tobi_WMDE_SW moved this task from Incoming to Work in progress on the Phragile board.
Tobi_WMDE_SW moved this task from Work in progress to Done on the Phragile board.
Tobi_WMDE_SW subscribed.