Page MenuHomePhabricator

Want to contribute to the project
Closed, ResolvedPublic

Description

Hi Thomas, I've tried to write to Mobile-l@wikimedia.org and I received this error:

Technical details of permanent failure:
Google tried to deliver your message, but it was rejected by the server for the recipient domain wikimedia.org by mx1001.wikimedia.org. [2620:0:861:3:208:80:154:76].

I also tried to write to iOS@wikimedia.org and I received this one:

We're writing to let you know that the group you tried to contact (ios) may not exist, or you may not have permission to post messages to the group. A few more details on why you weren't able to post:


I just wanted to send the following email to the team, I copy and paste this below:

Hi guys,

I would like to start contributing to the project. I live in Berlin and I estimate I could spend 3 to 4 hours a week, might be more.

I was able to compile and run the project and right now I'm running the test after doing some changes.

I've started with a review of the source code, to detect some possible code styles missing, just to get familiarized with the coding standards.

I think some day this week, or the next one I would like to document the general architecture. I saw that this section is still pending on github. I'd need you to recommend some tool to do that, is there any UML tool you would like me to use in particular?.

I also need also some help, because I'm trying to push a branch with my changes but I'm getting permissions errors:

remote: Permission to wikimedia/wikipedia-ios.git denied to barbaramartina.
fatal: unable to access 'https://github.com/wikimedia/wikipedia-ios.git/': The requested URL returned error: 403

Probably would you need to add me in someway to the repo in order to be able to push?

Thanks!

Barbara

Related Objects

StatusSubtypeAssignedTask
Resolved BGerstle-WMF

Event Timeline

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
barbarar assigned this task to Gymel.
barbarar triaged this task as Medium priority.
barbarar updated the task description. (Show Details)
barbarar changed Security from None to Access Request.
barbarar edited subscribers, added: barbarar; removed: Aklapper, StudiesWorld.
Gymel removed Gymel as the assignee of this task.Jan 19 2016, 2:20 PM

@barbarar you shouldn't need ops access. please visit lists.wikimedia.org, subscribe to mobile-l, and then you should be able to send & receive mail to/from mobile-l@lists.wikimedia.org.

remote: Permission to wikimedia/wikipedia-ios.git denied to barbaramartina.
fatal: unable to access 'https://github.com/wikimedia/wikipedia-ios.git/': The requested URL returned error: 403

This is because you're not a "collaborator" or "owner" of the GitHub repo. You'll need to fork the project, then submit a pull request for the changes on your fork. If you're unfamiliar with the GitHub workflow, please read their docs on how to collaborate using pull requests and feel free to ping us with any questions you may have. The setup/workflow for you should involve:

  1. Forking the repo
  2. Cloning the repo and setting it up with both remotes:
    • Original repo (sometimes called origin or upstream) pointing to wikimedia/wikipedia-ios. I'll refer to this as the "upstream" remote for clarity, since origin is the default remote name and can refer to either depending on what you already have cloned
    • Forked repo (I usually just call it bgerstle when I fork projects under my user)
  3. Checking out upstream/master so you can easily pull upstream changes and ensure your pull requests are based on the latest upstream code
  4. Checking out a feature branch to make your changes in (i.e. git checkout -b feature/foo)
  5. Now you can make as many commits as you want, then push them up to your remote (i.e. git push -u barbar feature/foo)
  6. Go to the original repo, and create a pull request to merge the changes on your fork to the original repo!

@BGerstle-WMF thanks! I supposed I should work as a collaborator.
I will fork the repo and will create a PR.

Regarding the UML tool... any suggestion? or could I use any I consider good?

@barbarar RE: UML docs, we haven't given documentation too much thought, but what we've done so far is comprised of:

In other words, things that are as close to the source of truth (i.e. code) as possible, making it easy to discover and update. We might employ some diagrams in the future, but the architecture has experience a high degree of volatility until recently, so now might be the time to start sketching things out.

Krenair changed Security from Access Request to None.Jan 19 2016, 4:10 PM

I see... so it might be better not to generate any UML docs now... I was thinking about reviewing the project looking for not used methods and unused classes... what do you think about that? I think is very important to have the base source as small in size as possible, makes knowledge acquisition easier and faster, as well as keep the code updated with the functionality is really used... I do not know if there are unused classes or methods... but if it were the case it might make sense for me to do this task also as an initial contact with the code.

@barbarar we're always happy to see dead code get deleted!

I'll try to get the team to start doing this more diligently, but there's an good first task project/tag which is meant to help new contributors find tasks to work on. Unfortunately, there's only one easy task in our backlog & dev boards 😔.

if you're feeling brave, you can look through the "Needs Triage," "Bug Backlog" and "Ready for Dev" columns on our product & dev boards for tasks that seem small and/or well defined.

mm... ok, I will check these task categories on Phabricator... anyway I
will do the code cleanup, it's a good way for me to start... I will do a PR
might be and you can just ignore it until you decide it would be worth to
integrate or not... I would not like to start doing any task until I get a
taste of the code and architecture... so in the meantime I will do
things to approach the code from different angles, it's ok if the PR are
not integrated... or I don't know might be I will just do it on my forked
version... or in a local one...

@barbarar sounds good, i'll be sure to mention you if I come across a task that I think would be good to start on (and tag it as easy).

BGerstle-WMF claimed this task.

@barbarar I'm going to resolve this ticket since there's no work attached to it. Feel free to continue the discussion on IRC and/or mobile-l

Great thanks ! Talk to you soon

RobH closed subtask Restricted Task as Resolved.Feb 10 2016, 8:13 PM