Ensure all libraries used in the app are attributed correctly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• BGerstle-WMF
	Jan 19 2016, 3:47 PM

Project Tags

Referenced Files

	F3434218: IMG_0085 (1).PNG
	Feb 27 2016, 12:09 AM

	F3434214: IMG_0083.PNG
	Feb 27 2016, 12:09 AM

	F3434216: IMG_0084 (1).PNG
	Feb 27 2016, 12:09 AM

	F3434220: IMG_0086.PNG
	Feb 27 2016, 12:09 AM

Subscribers

Description

Update "About the app" / "Licenses" to include all libraries integrated via CocoaPods
Add license of any code which was included directly in the repo (e.g. via submodules or copy/pasted)
- NSDate-Extensions from Erica Sadun
Add "detail" view where full license text is viewable (e.g. using this handy library: https://github.com/vtourraine/VTAcknowledgementsViewController)
- Manually correct CocoaPods-generated license data which is incorrect (e.g. PromiseKit & HockeySDK, etc.)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T127394 EPIC: Text Changes
		Resolved		• Fjalapeno	T124050 Ensure all libraries used in the app are attributed correctly

Event Timeline

• BGerstle-WMF created this task.Jan 19 2016, 3:47 PM

• BGerstle-WMF raised the priority of this task from to High.

• BGerstle-WMF updated the task description. (Show Details)

• BGerstle-WMF added a project: Wikipedia-iOS-App.

• BGerstle-WMF moved this task to Engineering Backlog on the Wikipedia-iOS-App board.

• BGerstle-WMF subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2016, 3:47 PM

• BGerstle-WMF updated the task description. (Show Details)Jan 19 2016, 3:49 PM

• BGerstle-WMF set Security to None.

• BGerstle-WMF moved this task from Engineering Backlog to Needs Estimation on the Wikipedia-iOS-App board.Jan 21 2016, 9:36 PM

• BGerstle-WMF edited projects, added: Wikipedia-iOS-App-Development, iOS-app-v5-production; removed: Wikipedia-iOS-App.Jan 21 2016, 9:44 PM

MBinder_WMF moved this task from Tasks from Product Backlog to Ready for Development on the Wikipedia-iOS-App-Development board.Jan 26 2016, 10:14 PM

MBinder_WMF lowered the priority of this task from High to Medium.Jan 26 2016, 10:59 PM

• JMinor lowered the priority of this task from Medium to Low.Feb 8 2016, 8:07 PM

MBinder_WMF moved this task from Backlog to Epic: Text Changes on the iOS-app-v5-production board.Feb 16 2016, 11:24 PM

MBinder_WMF added a parent task: T127394: EPIC: Text Changes.Feb 18 2016, 11:19 PM

• Fjalapeno claimed this task.Feb 23 2016, 6:31 PM

• Fjalapeno moved this task from Ready for Development to Doing on the Wikipedia-iOS-App-Development board.

need an asset and copy for a new menu item to show license information

• Fjalapeno moved this task from Doing to Blocked or Waiting on the Wikipedia-iOS-App-Development board.Feb 24 2016, 1:12 AM

• Fjalapeno moved this task from Blocked or Waiting to Doing on the Wikipedia-iOS-App-Development board.Feb 24 2016, 6:42 PM

• Fjalapeno moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.Feb 24 2016, 9:29 PM

• Fjalapeno mentioned this in rAPIOS2435718e7c07: Merge branch 'master' into feature/T124050/licenses.Feb 25 2016, 1:50 AM

• BGerstle-WMF mentioned this in rAPIOS1d622ecda242: Merge pull request #511 from wikimedia/feature/T124050/licenses.Feb 25 2016, 1:01 PM

• Fjalapeno moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Feb 25 2016, 5:58 PM

Checked with 5.0.0 (740) on iPhone 6S+ 9.2.1

From the top:

At the bottom with the reference to cocoapods.com

IMG_0084 (1).PNG (1,242×2,208 px, 152 KB)

@JMinor - please confirm that detail view is OK for the following:

IMG_0085 (1).PNG (1,242×2,208 px, 67 KB)

Etonkovidova raised the priority of this task from Low to Medium.Feb 27 2016, 12:11 AM

Etonkovidova moved this task from Needs QA to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.

@BGerstle-WMF there are a couple odd strings in here. I assume we are pulling these from some automated source and these strings are as the libraries author's have written them, but please confirm.

• JMinor lowered the priority of this task from Medium to Lowest.Feb 27 2016, 12:13 AM

@JMinor correct, it's all from GitHub as extracted by CocoaPods

• JMinor closed this task as Resolved.Feb 27 2016, 12:15 AM

i.e. those are the actual "LICENSE" files for the repo

Ensure all libraries used in the app are attributed correctlyClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Ensure all libraries used in the app are attributed correctly
Closed, ResolvedPublic
Actions

Related Objects
Search...