Page MenuHomePhabricator
Create Task
Maniphest T124143

Infinite recursion between user and session loading
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

fatal.log has lots of these.

2016-01-20 07:21:34 mw1256 mediawikiwiki fatal ERROR: [6cd6a432] PHP Fatal Error: Stack overflow {"exception_id":"6cd6a432"} 
[Exception ErrorException] (/srv/mediawiki/php-1.27.0-wmf.11/includes/libs/objectcache/MemcachedBagOStuff.php:177) PHP Fatal Error: Stack overflow
  #0 /srv/mediawiki/php-1.27.0-wmf.11/includes/libs/objectcache/MemcachedBagOStuff.php(177): NO_FUNCTION_GIVEN()
  #1 /srv/mediawiki/php-1.27.0-wmf.11/includes/objectcache/MemcachedPeclBagOStuff.php(208): MemcachedBagOStuff->debugLog(string)
  #2 /srv/mediawiki/php-1.27.0-wmf.11/includes/libs/objectcache/WANObjectCache.php(253): MemcachedPeclBagOStuff->getMulti(array)
  #3 /srv/mediawiki/php-1.27.0-wmf.11/includes/libs/objectcache/WANObjectCache.php(210): WANObjectCache->getMulti(array, array, array)
  #4 /srv/mediawiki/php-1.27.0-wmf.11/extensions/CentralAuth/includes/CentralAuthUser.php(410): WANObjectCache->get(string)
  #5 /srv/mediawiki/php-1.27.0-wmf.11/extensions/CentralAuth/includes/CentralAuthUser.php(284): CentralAuthUser->loadFromCache()
  #6 /srv/mediawiki/php-1.27.0-wmf.11/extensions/CentralAuth/includes/CentralAuthUser.php(2092): CentralAuthUser->loadState()
  #7 /srv/mediawiki/php-1.27.0-wmf.11/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php(144): CentralAuthUser->renameInProgress()
  #8 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/SessionManager.php(610): CentralAuthSessionProvider->provideSessionInfo(WebRequest)
  #9 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/SessionManager.php(190): MediaWiki\Session\SessionManager->getSessionInfoForRequest(WebRequest)
  #10 /srv/mediawiki/php-1.27.0-wmf.11/includes/WebRequest.php(661): MediaWiki\Session\SessionManager->getSessionForRequest(WebRequest)
  #11 /srv/mediawiki/php-1.27.0-wmf.11/includes/user/User.php(1089): WebRequest->getSession()
  #12 /srv/mediawiki/php-1.27.0-wmf.11/includes/user/User.php(378): User->loadDefaults()
  #13 /srv/mediawiki/php-1.27.0-wmf.11/includes/user/User.php(356): User->loadFromId(integer)
  #14 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/UserInfo.php(88): User->load()
  #15 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/CookieSessionProvider.php(116): MediaWiki\Session\UserInfo::newFromId(string)
  #16 /srv/mediawiki/php-1.27.0-wmf.11/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php(161): MediaWiki\Session\CookieSessionProvider->provideSessionInfo(WebRequest)
[repeat #8-16 ad inf.]

Details

SubjectRepoBranchLines +/-
Only check LoggedOut timestamp on the user loaded from sessionmediawiki/corewmf/1.27.0-wmf.11+1 -2
Only check LoggedOut timestamp on the user loaded from sessionmediawiki/coremaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tgr created this task.Jan 20 2016, 7:26 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: Wikimedia-production-error, MediaWiki-Core-AuthManager, Reading-Infrastructure-Team-Old (Don't use).
Tgr subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 20 2016, 7:26 AM
gerritbot subscribed.Jan 20 2016, 6:33 PM

Change 265304 had a related patch set uploaded (by Anomie):
Only check LoggedOut timestamp on the user loaded from session

https://gerrit.wikimedia.org/r/265304

gerritbot added a project: Patch-For-Review.Jan 20 2016, 6:33 PM
gerritbot added a comment.Jan 20 2016, 9:43 PM

Change 265304 merged by jenkins-bot:
Only check LoggedOut timestamp on the user loaded from session

https://gerrit.wikimedia.org/r/265304

greg subscribed.Jan 20 2016, 9:53 PM
gerritbot added a comment.Jan 20 2016, 10:11 PM

Change 265403 had a related patch set uploaded (by Gergő Tisza):
Only check LoggedOut timestamp on the user loaded from session

https://gerrit.wikimedia.org/r/265403

gerritbot added a comment.Jan 20 2016, 10:19 PM

Change 265403 merged by jenkins-bot:
Only check LoggedOut timestamp on the user loaded from session

https://gerrit.wikimedia.org/r/265403

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 20 2016, 11:01 PM
Tgr closed this task as Resolved.Jan 21 2016, 1:34 AM
Tgr claimed this task.
Tgr mentioned this in T124263: MediaWiki should trim stacktraces before logging to avoid truncation.

The errors are gone, so I am closing this. No clue what the user impact was, due to T124263.

Tgr added a parent task: T123451: Deploy SessionManager and bot passwords.Jan 21 2016, 1:37 AM
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Mar 11 2016, 11:58 PM
• Fjalapeno edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), Reading-Infrastructure-Team-Old (Don't use).Jun 7 2017, 2:57 PM
greg edited projects, added MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)); removed MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jun 7 2017, 5:34 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL