Page MenuHomePhabricator

Articles published with Content Translation contain gr-textarea-btn data-grammarly-reactid
Closed, ResolvedPublic

Event Timeline

Magioladitis raised the priority of this task from to Needs Triage.
Magioladitis updated the task description. (Show Details)
Magioladitis subscribed.
Nikerabbit renamed this task from CX adds useless div tags with gr-textarea-btn data-grammarly-reactid to Articles published with Content Translation contain gr-textarea-btn data-grammarly-reactid.Jan 20 2016, 2:56 PM
Nikerabbit set Security to None.
Nikerabbit subscribed.

CX does not do that, it is someone's proofreading browser extension: https://discuss.reactjs.org/t/invariant-failures-due-to-chrome-extensions-that-also-use-react/1765

That being said, we are responsible for preventing these in the published articles. As far as I know VE does this, which we are planning for long term. Maybe a blacklist is warranted for short therm.

I have sent Grammarly Support an email about this issue, so that they might be able to fix this long term as well, though that doesn't help us short term :)

Grammarly states:

I have escalated this to the development team. We are working to resolve this as quickly as possible.
Unfortunately, this will not be a quick fix and I cannot provide you with an estimated timeframe, as the developers will need some time to analyze the cause of this issue.

Support ID 820474

Amire80 moved this task from Needs Triage to Upstream/Other teams on the ContentTranslation board.

@TheDJ, thanks for poking them!

It's comparable to T111906 in VisualEditor, and some other similar issues.

I don't know if we can do much about it. Filtering particular unwanted tags doesn't scale (correct me if I'm wrong), and blocking all DOM manipulation is probably too restrictive (and I'm not even sure that it's possible).

But ideas are welcome, of course.

Hi, I'm a developer of Grammarly Chrome extension. I would like to help here.
Please help me to reproduce this case. I tried to edit those article in Visual mode and didn't manage to get our G-button inside contenteditable, it was outside.

@kigorw, thank you very much for replying!

It's about using ContentTranslation, not necessarily VisualEditor.

Can you please try starting a translation according to instructions at https://www.mediawiki.org/wiki/Help:Extension:ContentTranslation ? You don't have to publish it. Please contact me if you need any assistance.

Thanks, I reproduced. We will turn off Grammarly on those places on the next week or earlier. Do you have other places with the similar problems?

Thanks, I reproduced. We will turn off Grammarly on those places on the next week or earlier.

Wow, awesome! Thank you.

Do you have other places with the similar problems?

Not that I know.

In the latest Grammarly Chrome extension, this bug should not reproduce. Please check.

Amire80 claimed this task.

I don't quite know how to test it, but I'll trust @kigorw and close it. Please reopen if needed.

Thanks again!