Page MenuHomePhabricator

Fatal error: Cannot access protected property DiffEngine::$seq
Closed, ResolvedPublic

Description

This is possibly a HHVM issue (I am running nightly version since the latest release 3.11.0 is fatally broken).

Triggered by URLS such as w/i.php?title=Project:About/da&diff=6454985&oldid=4647374 or /w/api.php?hidebots=1&days=7&limit=50&action=feedrecentchanges&feedformat=atom.

Given there are no line numbers or file names, this might be related to assertions in DairikiDiff.php using $this:

459:            assert( '$y < $this->seq[$k]' );
510:            assert( '$ypos != $this->seq[$end]' );

See also https://github.com/facebook/hhvm/issues/5128 and T116266: Undefined property: DiffEngine::$seq.

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusAssignedTask
OpenNone
Resolvedori

Event Timeline

Nikerabbit updated the task description. (Show Details)
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit added a subscriber: Nikerabbit.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 20 2016, 1:15 PM
Nikerabbit updated the task description. (Show Details)Jan 20 2016, 1:16 PM
Nikerabbit set Security to None.
Nemo_bis added a subscriber: fred.
fred added a comment.Jan 20 2016, 6:03 PM

I'm not directly working on HHVM any more, though I'll see if I can get that issue prioritized: the trigger here is https://github.com/facebook/hhvm/commit/d7ce713deeb541e05c0b2b66c30114f6931c1bb5

Change 276082 had a related patch set uploaded (by Ori.livneh):
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276082

Change 276083 had a related patch set uploaded (by Ori.livneh):
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276083

Change 276084 had a related patch set uploaded (by Ori.livneh):
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276084

Change 276084 merged by Ori.livneh:
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276084

Change 276083 merged by Ori.livneh:
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276083

ori closed this task as Resolved.Mar 9 2016, 2:15 AM
ori claimed this task.

Change 276082 merged by jenkins-bot:
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276082

Change 294681 had a related patch set uploaded (by Lewis Cawte):
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/294681

lcawte added a subscriber: lcawte.

Cherrypicked this on to REL1_26 as it was breaking ShoutWiki.

Change 294681 merged by MaxSem:
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/294681