Page MenuHomePhabricator
Create Task
Maniphest T124163

Fatal error: Cannot access protected property DiffEngine::$seq
Closed, ResolvedPublic
Actions

Description

This is possibly a HHVM issue (I am running nightly version since the latest release 3.11.0 is fatally broken).

Triggered by URLS such as w/i.php?title=Project:About/da&diff=6454985&oldid=4647374 or /w/api.php?hidebots=1&days=7&limit=50&action=feedrecentchanges&feedformat=atom.

Given there are no line numbers or file names, this might be related to assertions in DairikiDiff.php using $this:

459:            assert( '$y < $this->seq[$k]' );
510:            assert( '$ypos != $this->seq[$end]' );

See also https://github.com/facebook/hhvm/issues/5128 and T116266: Undefined property: DiffEngine::$seq.

Details

ProjectBranchLines +/-Subject
mediawiki/coreREL1_26+23 -16Don't quote assert expressions in DairikiDiff
mediawiki/coremaster+16 -16Don't quote assert expressions in DairikiDiff
mediawiki/corewmf/1.27.0-wmf.16+16 -16Don't quote assert expressions in DairikiDiff
mediawiki/corewmf/1.27.0-wmf.15+16 -16Don't quote assert expressions in DairikiDiff
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Jan 20 2016, 1:15 PM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added projects: MediaWiki-Page-diffs, HHVM.
Nikerabbit added a subscriber: Nikerabbit.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 20 2016, 1:15 PM
Nikerabbit updated the task description. (Show Details)Jan 20 2016, 1:16 PM
Nikerabbit set Security to None.
Nikerabbit added a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].
Nemo_bis added a subscriber: fred.Jan 20 2016, 4:04 PM
Nemo_bis added a subscriber: Nemo_bis.
fred added a comment.Jan 20 2016, 6:03 PM

I'm not directly working on HHVM any more, though I'll see if I can get that issue prioritized: the trigger here is https://github.com/facebook/hhvm/commit/d7ce713deeb541e05c0b2b66c30114f6931c1bb5

Lazowik added a subscriber: Lazowik.Feb 19 2016, 2:04 PM
Florian added a subscriber: Florian.Feb 19 2016, 7:32 PM
Nemo_bis merged a task: T127699: Fatal error in diffs on HHVM 3.12.Feb 25 2016, 9:29 PM
alex-mashin added a subscriber: alex-mashin.Feb 28 2016, 10:32 AM
Nikerabbit mentioned this in T119637: Update HHVM package to recent release.Mar 1 2016, 12:37 PM
Ricordisamoa added a subscriber: Ricordisamoa.Mar 1 2016, 12:58 PM
gerritbot added a subscriber: gerritbot.Mar 9 2016, 2:03 AM

Change 276082 had a related patch set uploaded (by Ori.livneh):
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276082

gerritbot added a project: Patch-For-Review.Mar 9 2016, 2:03 AM

Change 276083 had a related patch set uploaded (by Ori.livneh):
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276083

gerritbot added a comment.Mar 9 2016, 2:05 AM

Change 276084 had a related patch set uploaded (by Ori.livneh):
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276084

gerritbot added a comment.Mar 9 2016, 2:06 AM

Change 276084 merged by Ori.livneh:
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276084

gerritbot added a comment.Mar 9 2016, 2:06 AM

Change 276083 merged by Ori.livneh:
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276083

ori closed this task as Resolved.Mar 9 2016, 2:15 AM
ori claimed this task.
gerritbot added a comment.Mar 9 2016, 2:36 AM

Change 276082 merged by jenkins-bot:
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/276082

Ricordisamoa removed a project: Patch-For-Review.Mar 9 2016, 3:01 AM
Ricordisamoa removed a subscriber: gerritbot.
ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)), MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-03-15_(1.27.0-wmf.17)).Mar 14 2016, 8:02 PM
Southparkfan mentioned this in T116266: Undefined property: DiffEngine::$seq.Apr 17 2016, 3:09 PM
gerritbot added a comment.Jun 16 2016, 9:53 AM

Change 294681 had a related patch set uploaded (by Lewis Cawte):
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/294681

gerritbot added a project: Patch-For-Review.Jun 16 2016, 9:53 AM
lcawte added a project: MW-1.26-release.Jun 16 2016, 9:56 AM
lcawte added a subscriber: lcawte.

Cherrypicked this on to REL1_26 as it was breaking ShoutWiki.

gerritbot added a comment.Jun 18 2016, 5:23 PM

Change 294681 merged by MaxSem:
Don't quote assert expressions in DairikiDiff

https://gerrit.wikimedia.org/r/294681

Aklapper edited projects, added MediaWiki-Page-history; removed MW-1.27-release (WMF-deploy-2016-03-15_(1.27.0-wmf.17)), MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Sep 20 2019, 7:47 PM
• Phabricator_maintenance added a project: affects-translatewiki.net.Sep 26 2019, 1:53 PM
• Phabricator_maintenance removed a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Sep 26 2019, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL