Page MenuHomePhabricator
Create Task
Maniphest T124188

Use same OOUI widgets for notifications popup on mobile and desktop
Closed, ResolvedPublic
Actions

Description

MobileFrontend has its own, completely separate, implementation of the notifications popup. This means the mobile site didn't break when we OOUIified the notifications popup on desktop, but it also doesn't get anything new (and so e.g. cross-wiki notifications won't work there). We should instead reuse the OOUI widgets that the desktop site uses.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Echomaster+3 -1[wip] Adjust and clean up styles and behavior for mobile
mediawiki/extensions/MobileFrontendmaster+77 -158OOUIfying Echo in MobileFrontend
mediawiki/extensions/Echomaster+140 -23Add MobileNotificationsWrapper for Mobile display
Customize query in gerrit

Event Timeline

Catrope created this task.Jan 20 2016, 5:23 PM
Catrope raised the priority of this task from to High.
Catrope updated the task description. (Show Details)
Catrope added projects: Notifications, Mobile, MobileFrontend.
Catrope added a subscriber: Catrope.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 20 2016, 5:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Jan 20 2016, 5:23 PM
Catrope set Security to None.
gerritbot added a subscriber: gerritbot.Jan 20 2016, 5:23 PM

Change 237510 had a related patch set uploaded (by Catrope):
[wip] Adjust and clean up styles and behavior for mobile

https://gerrit.wikimedia.org/r/237510

gerritbot added a project: Patch-For-Review.Jan 20 2016, 5:23 PM

Change 237509 had a related patch set uploaded (by Catrope):
OOUIfying Echo in MobileFrontend

https://gerrit.wikimedia.org/r/237509

Catrope moved this task from Untriaged to RFP (cross-wiki notifications) on the Collaboration-Team-Archive-2015-2016 board.Jan 20 2016, 5:25 PM
Jdlrobson changed the task status from Open to Stalled.Jan 20 2016, 7:57 PM
Jdlrobson added a subscriber: Jdlrobson.

This is stalled on the upstream change https://gerrit.wikimedia.org/r/#/c/251561/
Please mark as open when you need help reviewing from mobile team.

Mooeypoo claimed this task.Jan 20 2016, 8:09 PM
Mooeypoo added a subscriber: Mooeypoo.

Working on both of those now.

gerritbot added a comment.Jan 20 2016, 11:06 PM

Change 251561 had a related patch set uploaded (by Mooeypoo):
Add MobileNotificationsWrapper for Mobile display

https://gerrit.wikimedia.org/r/251561

Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Feb 18 2016, 6:41 PM
Jdlrobson moved this task from Team:Growth to team:other on the MobileFrontend board.
Mooeypoo moved this task from RFP (cross-wiki notifications) to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Feb 26 2016, 8:53 PM

Please notice that in order to test this, you need to pull the patch for MobileFrontend: https://gerrit.wikimedia.org/r/#/c/237509/ and the patch for Echo https://gerrit.wikimedia.org/r/#/c/251561/

Catrope moved this task from Needs Review to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.Mar 12 2016, 12:20 AM
gerritbot added a comment.Mar 16 2016, 5:57 PM

Change 251561 merged by jenkins-bot:
Add MobileNotificationsWrapper for Mobile display

https://gerrit.wikimedia.org/r/251561

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 16 2016, 6:00 PM
gerritbot added a comment.Mar 16 2016, 6:27 PM

Change 237509 merged by jenkins-bot:
OOUIfying Echo in MobileFrontend

https://gerrit.wikimedia.org/r/237509

Jdlrobson closed this task as Resolved.Mar 16 2016, 9:25 PM

Thanks guys!! Now let me source some Stroopwafels...

gerritbot added a comment.May 11 2016, 10:06 PM

Change 237510 abandoned by Mooeypoo:
[wip] Adjust and clean up styles and behavior for mobile

Reason:
No longer relevant.

https://gerrit.wikimedia.org/r/237510

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL