Page MenuHomePhabricator

When importing new TemplateData parameters, there's no reason to warn about the old parameters
Closed, ResolvedPublic

Description

Extension:TemplateData has a wonderful feature: if you add a parameter to your template, the "Manage TemplateData" GUI editor automatically notices and asks if you want to import it.

Add 1 suggested parameter
Including: age

If you say yes, however, the GUI displays a long response that sounds like a problem occurred:

Some parameters were not imported, because they already exist in the editor: name, address, zipcode, color, issmall, message

I suggest you get rid of the above message. All you need is the second line, informing the user that the new parameters were imported.

1 new parameter was imported: age

Event Timeline

maiden_taiwan raised the priority of this task from to Needs Triage.
maiden_taiwan updated the task description. (Show Details)
maiden_taiwan added a project: TemplateData.
maiden_taiwan added a subscriber: maiden_taiwan.

I thought about setting the associated system message, templatedata-modal-errormsg-import-paramsalreadyexist, to the empty string. But I don't know if this message is used in other places (where it's more needed).

Change 265410 had a related patch set uploaded (by Alex Monk):
Don't show warning about already-known parameters that weren't imported

https://gerrit.wikimedia.org/r/265410

Change 265410 merged by jenkins-bot:
Don't show warning about already-known parameters that weren't imported

https://gerrit.wikimedia.org/r/265410

Krenair claimed this task.
Krenair moved this task from Backlog to Doing on the TemplateData board.