Page MenuHomePhabricator

No duplicate ref error when duplicate refs are defined inside {{#tag:references}}
Closed, ResolvedPublic

Description

No duplicate ref error is displayed when duplicate refs are defined inside {{#tag:references}}.

Sorry, @matmarex, does not work in all the cases. Try

jkghjkgj<ref name=a/>ghjgkgk
{{#tag:references|<ref name=a>jkhkhk</ref><ref name=a>jkhkghfhk</ref>}}

Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: Cite.
matmarex added subscribers: matmarex, IKhitron.

Change 262330 had a related patch set uploaded (by Bartosz Dziewoński):
[WIP] Keep error messages about duplicate refs when fixing out-of-order tags

https://gerrit.wikimedia.org/r/262330

Change 265379 had a related patch set uploaded (by Bartosz Dziewoński):
Rollback all, then redo all, when fixing out-of-order tags; not one-by-one

https://gerrit.wikimedia.org/r/265379

Change 262330 abandoned by Bartosz Dziewoński:
[WIP] Keep error messages about duplicate refs when fixing out-of-order tags

Reason:
This seemed clever, but doesn't fix the problem. https://gerrit.wikimedia.org/r/#/c/265379/ is an actual fix.

https://gerrit.wikimedia.org/r/262330

matmarex triaged this task as Medium priority.
matmarex set Security to None.

Change 265379 merged by jenkins-bot:
Rollback all, then redo all, when fixing out-of-order tags; not one-by-one

https://gerrit.wikimedia.org/r/265379

This has been fixed and will be deployed to Wikimedia wikis soon, see https://www.mediawiki.org/wiki/MediaWiki_1.27/Roadmap for details.