Page MenuHomePhabricator
Create Task
Maniphest T124316

On single edit tab wikis: Switching from VE to the wikitext editor (discarding changes) while having "always give me the visual editor" as your preference causes VE to load up again
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

<Kemayo> Krenair: Fun single-edit-tab interaction... if you have the "always give me the visual editor" preference set, then clicking the edit-source VE toolbar button opens up the wikitext editor and immediately does a redirect to visual editor again.

Details

SubjectRepoBranchLines +/-
Don't try to load VE over the top of the wikitext editor we just switched tomediawiki/extensions/VisualEditormaster+3 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT265163 Create a system to encode best practices into editing experiences
 OpenTrizek-WMFT331946 [RELEASE TICKET] Make Edit Check (references) available to all newcomers at all Wikipedias
 OpenNoneT52000 Enable VisualEditor by default for all users of all Wikimedia wikis
 OpenNoneT51999 Enable VisualEditor by default for all users of all Wikipedias
 OpenNoneT90662 Re-enable VisualEditor by default for all users of the English Wikipedia
 OpenNoneT90663 Re-enable VisualEditor by default for all logged-out users of the English Wikipedia
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 ResolvedKrenairT55441 VisualEditor: Where VisualEditor is the primary editor, redlinks in read mode should open VE (not wikitext editor)
 Resolved• AlexMonk-WMFT55746 VisualEditor: [[MediaWiki:Anoneditwarning]] has an editor-specific link rather than taking you to the appropriate one
 OpenNoneT114531 VE should intercept all calls to action=edit (undo, diffs, etc.) to apply consistently for user expectation
 ResolvedKrenairT89060 VisualEditor is not the editor linked from the diff page
 OpenNoneT78550 The undo link in the page history leads to the source editor and not VisualEditor
 OpenNoneT185548 Undo notification is not sent if the editor switches to the visual editor
 OpenNoneT54162 VisualEditor: If VisualEditor is the primary editor, type=create and type=fulltext buttons should point to VE, not WT editor
 OpenNoneT102398 Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them
 ResolvedKrenairT54281 VisualEditor: VE should use the existing "action" URL parameter instead of the new "veaction"
 ResolvedKrenairT58337 Change VE integration to only use one edit tab, to avoid user choice paralysis
 ResolvedKrenairT124316 On single edit tab wikis: Switching from VE to the wikitext editor (discarding changes) while having "always give me the visual editor" as your preference causes VE to load up again

Event Timeline

Krenair created this task.Jan 21 2016, 6:31 PM
Krenair raised the priority of this task from to Needs Triage.
Krenair updated the task description. (Show Details)
Krenair added projects: VisualEditor-MediaWiki, VisualEditor.
Krenair added subscribers: Krenair, DLynch.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 21 2016, 6:31 PM
Krenair added a parent task: T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.Jan 21 2016, 6:31 PM
Krenair renamed this task from On single edit tab wikis: Switching from VE to the wikitext editor while having "always give me the visual editor" as your preference causes VE to load up again to On single edit tab wikis: Switching from VE to the wikitext editor (discarding changes) while having "always give me the visual editor" as your preference causes VE to load up again.Jan 23 2016, 5:27 AM
Krenair claimed this task.
Krenair set Security to None.
gerritbot subscribed.Jan 23 2016, 5:30 AM

Change 265903 had a related patch set uploaded (by Alex Monk):
Don't try to load VE over the top of the wikitext editor we just switched to

https://gerrit.wikimedia.org/r/265903

gerritbot added a project: Patch-For-Review.Jan 23 2016, 5:30 AM
Krenair mentioned this in T124650: On single edit tab wikis, if your preference is 'remember last editor' and you last used VisualEditor, VisualEditor will load on a "View source" action=edit.Jan 26 2016, 3:00 PM
• Elitre subscribed.Jan 26 2016, 3:00 PM
gerritbot added a comment.Jan 26 2016, 5:01 PM

Change 265903 merged by jenkins-bot:
Don't try to load VE over the top of the wikitext editor we just switched to

https://gerrit.wikimedia.org/r/265903

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 26 2016, 5:02 PM
Jdforrester-WMF closed this task as Resolved.Jan 26 2016, 8:22 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits