Page MenuHomePhabricator

Some Echo messages don't appear on the live site, even though they were translated
Closed, InvalidPublic

Description

Important: The message Notification-bundle-header-edit-user-talk-v2 appears untranslated in the Hebrew Wikipedia, even though it was translated on January 19 and exported to Gerrit on the same day. Today is January 22, so I'd expect LocalisationUpdate to bring it to production already.

Less important: I also see two PageTriage notification messages as untranslated in the Hebrew Wikipedia: notification-header-pagetriage-add-deletion-tag and notification-header-pagetriage-add-maintenance-tag. I noticed them while going over Special:AllMessages. By itself, it's much less important because PageTriage is not used in the Hebrew Wikipedia, but it may hint at a larger issue.

Event Timeline

Amire80 created this task.Jan 22 2016, 1:51 PM
Amire80 raised the priority of this task from to High.
Amire80 updated the task description. (Show Details)
Amire80 added subscribers: Amire80, Nikerabbit, KartikMistry and 2 others.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 22 2016, 1:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added a subscriber: Reedy.Jan 22 2016, 2:00 PM

Probably a dupe of T103879

So wearing my Holmes gloves:

"messages:notification-bundle-header-edit-user-talk-v2":"s:62:\"$1 new {{PLURAL:$2|messages}} on {{GENDER:$3|your}} talk page.\";",

appears in:

/srv/mediawiki/php-1.27.0-wmf.11/cache/l10n/l10n_cache-he.cdb
/srv/mediawiki-staging/php-1.27.0-wmf.11/cache/l10n/l10n_cache-he.cdb
/srv/mediawiki-staging/php-1.27.0-wmf.11/cache/l10n/upstream/l10n_cache-he.cdb.json

The clones are properly updated:

/var/lib/l10nupdate/mediawiki/extensions/Echo/i18n/he.json:
        "notification-bundle-header-edit-user-talk-v2": "{{PLURAL:$2|הודעה חדשה אחת|$1 הודעות חדשות}} בדף השיחה {{GENDER:$3|שלך}}",

However LU does not pick this up for some reason:

/var/lib/l10nupdate/caches/cache-1.27.0-wmf.11/l10nupdate-he.json:
{
    "randomrootpage": "\u05d3\u05e3 \u05e9\u05d5\u05e8\u05e9 \u05d0\u05e7\u05e8\u05d0\u05d9",
    "notification-header-reverted": "{{PLURAL:$4|\u05d4\u05e2\u05e8\u05d9\u05db\u05d4 {{GENDER:$2|\u05e9\u05dc\u05da}} \u05d1\u05d3\u05e3 $3 \u05e9\u05d5\u05d7\u05d6\u05e8\u05d4|\u05d4\u05e2\u05e8\u05d9\u05db\u05d5\u05ea \u05e9\u05dc\u05da \u05d1\u05d3\u05e3 $3 \u05e9\u05d5\u05d7\u05d6\u05e8\u05d5}}"
}
Nikerabbit closed this task as Invalid.Jan 22 2016, 2:32 PM
Nikerabbit claimed this task.

This behavior is as expected:

--- /var/lib/l10nupdate/mediawiki/extensions/Echo/i18n/en.json  2016-01-22 02:02:11.657512004 +0000
+++ /srv/mediawiki/php-1.27.0-wmf.11/extensions/Echo/i18n/en.json       2016-01-19 19:38:12.000000000 +0000
@@ -53,7 +53,6 @@
        "echo-feedback": "Feedback",
        "echo-quotation-marks": "\"$1\"",
        "echo-api-failure": "Could not retrieve notifications. Please try again. (Error $1)",
-       "echo-api-failure-cross-wiki": "Access to the remote domain was denied.",
        "echo-notification-placeholder": "There are no notifications.",
        "echo-notification-loginrequired": "You must login to see your notifications.",
        "echo-notification-popup-loginrequired": "Please log in to view your notifications.",
@@ -127,7 +126,7 @@
        "echo-date-yesterday": "Yesterday",
        "echo-load-more-error": "An error occurred while fetching more results.",
        "notification-edit-talk-page-bundle": "$1 and $3 {{PLURAL:$4|other|others}} {{GENDER:$1|left}} messages on your [[User talk:$2|talk page]].",
-       "notification-bundle-header-edit-user-talk-v2": "$1 new {{PLURAL:$2|message|messages}} on {{GENDER:$3|your}} talk page.",
+       "notification-bundle-header-edit-user-talk-v2": "$1 new {{PLURAL:$2|messages}} on {{GENDER:$3|your}} talk page.",
        "notification-edit-user-talk-email-batch-bundle-body": "$1 and $2 {{PLURAL:$3|other|others}} {{GENDER:$1|left}} a message on your talk page.",
        "notification-page-linked-email-batch-bundle-body": "$2 was {{GENDER:$1|linked}} from $3 and $4 other {{PLURAL:$5|page|pages}}.",
        "echo-email-batch-separator": "--",

Huh? Ultimately, the expected behavior is that the the live site would show the latest translation according to the version that is currently running. Currently no translation is displayed.

If there was a version conflict, it's something that shouldn't happen.

Huh? Ultimately, the expected behavior is that the the live site would show the latest translation according to the version that is currently running. Currently no translation is displayed.

I am talking about the expected behavior as designer of the code. There is no translation matching the English string currently running in production: following safety principle we cannot know if the translation in master belongs to the previous or current English string so we don't use it.

If there was a version conflict, it's something that shouldn't happen.

I don't know what you mean with version conflict. That term is not used in this context.