2016-01-22 15:05:02 mw1115 jawiki exception ERROR: [45abfdf9] /w/api.php?action=cirrus-suggest&format=json&text=%7B%7B%E5%9F%BA%E7%A4%8E%E6%83%85%E5%A0%B1+%E4%B8%AD%E5%9B%BD%E3%81%AE%E9%83%BD%E5%B8%82&limit=10 BadMethodCallException from line 397 of /srv/mediawiki/php-1.27.0-wmf.11/extensions/CirrusSearch/includes/CirrusSearch.php: Call to a member function getNamespace() on a non-object (NULL) {"exception_id":"45abfdf9"} [Exception BadMethodCallException] (/srv/mediawiki/php-1.27.0-wmf.11/extensions/CirrusSearch/includes/CirrusSearch.php:397) Call to a member function getNamespace() on a non-object (NULL) #0 /srv/mediawiki/php-1.27.0-wmf.11/extensions/CirrusSearch/includes/Api/Suggest.php(41): CirrusSearch->searchSuggestions(string) #1 /srv/mediawiki/php-1.27.0-wmf.11/includes/api/ApiMain.php(1308): CirrusSearch\Api\Suggest->execute() #2 /srv/mediawiki/php-1.27.0-wmf.11/includes/api/ApiMain.php(460): ApiMain->executeAction() #3 /srv/mediawiki/php-1.27.0-wmf.11/includes/api/ApiMain.php(432): ApiMain->executeActionWithErrorHandling() #4 /srv/mediawiki/php-1.27.0-wmf.11/api.php(83): ApiMain->execute() #5 /srv/mediawiki/w/api.php(3): include(string) #6 {main}
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Fix Call to a member function getNamespace() on a non-object | mediawiki/extensions/CirrusSearch | master | +1 -1 |
Event Timeline
Change 265782 had a related patch set uploaded (by DCausse):
Fix Call to a member function getNamespace() on a non-object
Change 265782 merged by jenkins-bot:
Fix Call to a member function getNamespace() on a non-object
@EBernhardson thinks this log error should be pretty rare, so this probably doesn't need a SWAT deploy. I'm calling this done.
You sure?
reedy@fluorine:/a/mw-log$ grep getNamespace exception.log -c
2546
(and yes, it's all Cirrus stuff)
No. But, the fact that there's ~2,000 errors caused by individual searches is a drop in the water relative to our total number of searches. So what you've said and what @EBernhardson said are not necessarily inconsistent.
Regardless, this will be deployed in next week's train deploy, so we are only talking about a difference of a few days here.