Page MenuHomePhabricator

Not all MassMessage sent
Closed, ResolvedPublic

Event Timeline

Steinsplitter raised the priority of this task from to High.
Steinsplitter updated the task description. (Show Details)
Steinsplitter added a subscriber: Steinsplitter.

T124414 has been fixed and the fix backported, can you try again and see if it works now?

Eh, this is probably different:

legoktm@terbium:~$ ./jobs.sh commonswiki
MassMessageJob: 0 queued; 137 claimed (0 active, 137 abandoned); 0 delayed

Heh, actually it's the same:

2016-01-22 14:50:16 mw1167 commonswiki exception ERROR: [d4c530b5] /rpc/RunJobs.php?wiki=commonswiki&type=MassMessageJob&maxtime=30&maxmem=300M   MWException from line 3662 of /srv/mediawiki/php-1.27.0-wmf.11/includes/user/User.php: CAS update failed on user_touched for user ID '3267792' (read from slave); the version of the user to be saved is older than the current version. {"exception_id":"d4c530b5"} 
[Exception MWException] (/srv/mediawiki/php-1.27.0-wmf.11/includes/user/User.php:3662) CAS update failed on user_touched for user ID '3267792' (read from slave); the version of the user to be saved is older than the current version.
  #0 /srv/mediawiki/php-1.27.0-wmf.11/includes/session/SessionManager.php(534): User->saveSettings()
  #1 /srv/mediawiki/php-1.27.0-wmf.11/includes/user/User.php(679): MediaWiki\Session\SessionManager->preventSessionsForUser(string)
  #2 /srv/mediawiki/php-1.27.0-wmf.11/extensions/MassMessage/includes/MassMessage.php(44): User::newSystemUser(string, array)
  #3 /srv/mediawiki/php-1.27.0-wmf.11/extensions/MassMessage/includes/job/MassMessageJob.php(171): MassMessage::getMessengerUser()
  #4 /srv/mediawiki/php-1.27.0-wmf.11/extensions/MassMessage/includes/job/MassMessageJob.php(164): MassMessageJob->editPage()
  #5 /srv/mediawiki/php-1.27.0-wmf.11/extensions/MassMessage/includes/job/MassMessageJob.php(35): MassMessageJob->sendMessage()
  #6 /srv/mediawiki/php-1.27.0-wmf.11/includes/jobqueue/JobRunner.php(257): MassMessageJob->run()
  #7 /srv/mediawiki/php-1.27.0-wmf.11/includes/jobqueue/JobRunner.php(176): JobRunner->executeJob(MassMessageJob, BufferingStatsdDataFactory, integer)
  #8 /srv/mediawiki/rpc/RunJobs.php(45): JobRunner->run(array)
  #9 {main}

I'll figure out how to retrigger the jobs.

Change 265823 had a related patch set uploaded (by Aaron Schulz):
Make preventSessionsForUser() use READ_LATEST

https://gerrit.wikimedia.org/r/265823

Eh, this is probably different:

legoktm@terbium:~$ ./jobs.sh commonswiki
MassMessageJob: 0 queued; 137 claimed (0 active, 137 abandoned); 0 delayed

Should i send the msg's out again?

Eh, this is probably different:

legoktm@terbium:~$ ./jobs.sh commonswiki
MassMessageJob: 0 queued; 137 claimed (0 active, 137 abandoned); 0 delayed

Should i send the msg's out again?

hmm? This is blocking stuff of commons. We can't continue to work. :-/

Legoktm claimed this task.
legoktm@terbium:~$ mwscript eval.php --wiki=commonswiki
> $g=JobQueueGroup::singleton();

> $q=$g->get('MassMessageJob');

> $a=$q->getAllAbandonedJobs();

> $i=iterator_to_array($a);

> var_dump(count($i));
int(137)

> $g->push($i);

Change 265823 abandoned by Aaron Schulz:
Make preventSessionsForUser() use READ_LATEST

Reason:
code is gone now

https://gerrit.wikimedia.org/r/265823